Fix missing GC counter data on non-Windows#87430
Conversation
This sets FEATURE_EVENT_TRACE on non-Windows platforms as well, such that GC counter information is tracked and provided when requested. This does not fully enable runtime event tracing via EventPipe on non-Windows.
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas Issue DetailsThis sets This is only enough to enable the counter tracking (#87325). It does not fully enable event tracing via EventPipe on non-Windows. I manually verified by running
|
Is that with the EventSource support enabled via feature flag? Otherwise I thought we managed to avoid pulling in the event source stuff in helloworld. |
Only event pipe is separated out into an opt in library. We don't separate the event source support. I haven't looked how feasible it would be to put it into a separate static library that we could disable if event source is not enabled, but at 25 kB it's not worth too much effort. |
|
It is not with EventSource support enabled via feature flag. This enables code in the GC (currently enabled on Windows always) that keeps track of information that gets returned in counters - unlike eventpipe itself, we don't have separate enabled/disabled libs for the GC. |
This sets
FEATURE_EVENT_TRACEon non-Windows platforms as well, such that GC counter information is tracked and provided when requested.This is only enough to enable the counter tracking (#87325). It does not fully enable event tracing via EventPipe on non-Windows.
I manually verified by running
dotnet-counters monitor. The automated tests just verify the counters can be retrieved - which they could before, but some of them were just always 0.Pulling in whatever is under
FEATURE_EVENT_TRACEseems to be about +25kB on my helloworld app.