Enable reading process environment variables in EventPipe#87771
Merged
LakshanF merged 7 commits intodotnet:mainfrom Jul 6, 2023
Merged
Enable reading process environment variables in EventPipe#87771LakshanF merged 7 commits intodotnet:mainfrom
LakshanF merged 7 commits intodotnet:mainfrom
Conversation
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas Issue DetailsEnabled a test to CI
|
elinor-fung
approved these changes
Jul 5, 2023
Member
elinor-fung
left a comment
elinor-fung
left a comment
There was a problem hiding this comment.
Follows similar pattern as Mono's EventPipe implementation with support for Windows and Linux.
Can you also call this out as another example in that issue you filed some time ago around sharing code in event pipe implementations?
Contributor
Author
Updated #87069 |
This was referenced Jul 6, 2023
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows similar pattern as Mono's
EventPipeimplementation with support for Windows and Linux.