Fix missing GC events on non-Windows for nativeaot#88282
Merged
elinor-fung merged 6 commits intodotnet:mainfrom Jul 10, 2023
Merged
Fix missing GC events on non-Windows for nativeaot#88282elinor-fung merged 6 commits intodotnet:mainfrom
elinor-fung merged 6 commits intodotnet:mainfrom
Conversation
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas Issue Details
This does not change the ETW emitting, so that is still:
Fixes #87445
|
Member
nativeaot\Runtime\eventtrace.cpp and vm\eventtrace.cpp are same files. If you are splitting the nativeaot one into multiple files, you may consider doing the same for coreclr one too so that it is easier to compare and eventually unify. |
3b04711 to
b1fe7e4
Compare
b1fe7e4 to
764ccab
Compare
LakshanF
reviewed
Jul 6, 2023
LakshanF
reviewed
Jul 6, 2023
LakshanF
reviewed
Jul 6, 2023
LakshanF
reviewed
Jul 6, 2023
LakshanF
approved these changes
Jul 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FEATURE_EVENT_TRACEinstead of only for WindowsThis does not change the ETW emitting, so that is still:
Fixes #87445