HttpClientFactory logging configuration#88706
Merged
CarnaViire merged 10 commits intodotnet:mainfrom Jul 14, 2023
Merged
Conversation
ghost
added
the
|
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
|
Tagging subscribers to this area: @dotnet/ncl |
antonfirsov
reviewed
Jul 12, 2023
Contributor
antonfirsov
left a comment
antonfirsov
left a comment
There was a problem hiding this comment.
Only nitpicking for now.
src/libraries/Microsoft.Extensions.Http/src/HttpClientFactoryOptions.cs
Outdated
Show resolved
Hide resolved
src/libraries/Microsoft.Extensions.Http/src/DefaultHttpClientFactory.cs
Outdated
Show resolved
Hide resolved
...ies/Microsoft.Extensions.Http/src/DependencyInjection/HttpClientBuilderExtensions.Logging.cs
Show resolved
Hide resolved
src/libraries/Microsoft.Extensions.Http/src/Logging/HttpClientLoggerHandler.cs
Show resolved
Hide resolved
MihaZupan
reviewed
Jul 12, 2023
...ies/Microsoft.Extensions.Http/src/DependencyInjection/HttpClientBuilderExtensions.Logging.cs
Show resolved
Hide resolved
ManickaP
approved these changes
Jul 14, 2023
Member
ManickaP
left a comment
ManickaP
left a comment
There was a problem hiding this comment.
LGTM, but I'm not an expert in this area.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add 2 interfaces for custom sync and async HttpClient loggers, and extension methods to add or remove HttpClient loggers in AddHttpClient configuration.
/cc @noahfalk @JamesNK
Fixes #77312