Enable IOPack, IOEnqueue, and IODequeue on Windows#88894
Merged
eduardo-vp merged 22 commits intodotnet:mainfrom Aug 9, 2023
Merged
Enable IOPack, IOEnqueue, and IODequeue on Windows#88894eduardo-vp merged 22 commits intodotnet:mainfrom
eduardo-vp merged 22 commits intodotnet:mainfrom
Conversation
|
Tagging subscribers to this area: @mangod9 Issue Detailsnull
|
This was referenced Jul 14, 2023
LakshanF
reviewed
Jul 17, 2023
Contributor
|
The |
kouvel
reviewed
Jul 20, 2023
src/libraries/System.Private.CoreLib/src/System/Threading/WindowsThreadPool.cs
Show resolved
Hide resolved
LakshanF
reviewed
Aug 2, 2023
src/libraries/System.Private.CoreLib/src/System/Threading/Overlapped.cs
Outdated
Show resolved
Hide resolved
This was referenced Aug 3, 2023
LakshanF
approved these changes
Aug 4, 2023
Contributor
LakshanF
left a comment
LakshanF
left a comment
There was a problem hiding this comment.
This looks good to me from the NativeAOT perspective. Thanks for doing this work!
kouvel
reviewed
Aug 7, 2023
...raries/System.Private.CoreLib/src/System/Threading/RegisteredWaitHandle.WindowsThreadPool.cs
Outdated
Show resolved
Hide resolved
...aries/System.Private.CoreLib/src/System/Threading/ThreadPoolBoundHandle.WindowsThreadPool.cs
Outdated
Show resolved
Hide resolved
...aries/System.Private.CoreLib/src/System/Threading/ThreadPoolBoundHandle.WindowsThreadPool.cs
Outdated
Show resolved
Hide resolved
...aries/System.Private.CoreLib/src/System/Threading/ThreadPoolBoundHandle.WindowsThreadPool.cs
Outdated
Show resolved
Hide resolved
kouvel
reviewed
Aug 8, 2023
Contributor
kouvel
left a comment
kouvel
left a comment
There was a problem hiding this comment.
Just one comment, otherwise LGTM, thanks!
...aries/System.Private.CoreLib/src/System/Threading/ThreadPoolBoundHandle.WindowsThreadPool.cs
Show resolved
Hide resolved
kouvel
approved these changes
Aug 8, 2023
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #87020