JIT: stop creating gc poll blocks in morph#93816
Merged
AndyAyersMS merged 1 commit intodotnet:mainfrom Oct 22, 2023
Merged
Conversation
Instead, mark the block as needing a GC poll and add one later in the normal GC poll insertion phase. This only impacts x86. This change also stops creating inline GC polls for these cases in unoptimized code.
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsInstead, mark the block as needing a GC poll and add one later in the normal GC poll insertion phase. This only impacts x86. This change also stops creating inline GC polls for these cases in unoptimized code.
|
Member
Author
|
@jakobbotsch PTAL |
12 tasks
jakobbotsch
approved these changes
Oct 21, 2023
Member
can it be related? (jitstress) can be also pre-existing issue or my PR |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead, mark the block as needing a GC poll and add one later in the normal GC poll insertion phase. This only impacts x86.
This change also stops creating inline GC polls for these cases in unoptimized code.