JIT: Clean up GenTreeCallFlags, remove INLINE_DATA define#93830
Merged
jakobbotsch merged 7 commits intodotnet:mainfrom Oct 24, 2023
Merged
JIT: Clean up GenTreeCallFlags, remove INLINE_DATA define#93830jakobbotsch merged 7 commits intodotnet:mainfrom
jakobbotsch merged 7 commits intodotnet:mainfrom
Conversation
This does not compile anymore, and keeping it requires additional handling for the new call debug flags which seems unnecessary if it is not being used anymore.
ghost
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue Details
Overall this frees up 6 bits in No diffs are expected.
|
Member
Author
|
/azp run runtime-coreclr jitstress, runtime-coreclr libraries-jitstress |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Member
Author
|
Failures are known. No diffs except for some TP ones. cc @dotnet/jit-contrib PTAL @AndyAyersMS |
AndyAyersMS
approved these changes
Oct 23, 2023
src/coreclr/jit/inline.cpp
Outdated
| , m_Policy(nullptr) | ||
| , m_TreeID(0) | ||
| #endif // defined(DEBUG) || defined(INLINE_DATA) | ||
| #endif // defined(DEBUG) |
Member
There was a problem hiding this comment.
Fuse this with the bit just below?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GenTreeCall::gtCallDebugFlagsfield that contains flags we only need in debugGTF_CALL_M_STRESS_TAILCALL,GTF_CALL_M_DEVIRTUALIZED,GTF_CALL_M_UNBOXED,GTF_CALL_M_GUARDEDinto the new debug-only flagsGTF_CALL_M_R2R_REL_INDIRECT; we can get that information fromgtEntryPointGTF_CALL_M_EXP_TLS_ACCESS; we can get this by just checking the helper numINLINE_DATAdefine; it no longer compiles, and it would need extra work to with the new flags, which seemed unnecessary since it isn't being usedOverall this frees up 6 bits in
GenTreeCallFlags.No diffs are expected.