JsonSerializerOptions.Web for JsonSerializerOptions#94370
JsonSerializerOptions.Web for JsonSerializerOptions#94370eiriktsarpalis merged 5 commits intodotnet:mainfrom
JsonSerializerOptions.Web for JsonSerializerOptions#94370Conversation
|
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
|
Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis Issue Detailsnull
|
src/libraries/System.Text.Json/src/System/Text/Json/Serialization/JsonSerializerOptions.cs
Outdated
Show resolved
Hide resolved
JsonSerializerOptions.Web for JsonSerializerOptions
|
May i change all statement in dontent/runtime |
src/libraries/System.Text.Json/src/System/Text/Json/Serialization/JsonSerializerOptions.cs
Outdated
Show resolved
Hide resolved
Yes, where possible, but most of these cases would involve removing the static readonly field entirely and just changing call sites to use the new property directly. |
There was a problem hiding this comment.
This test is checking the behavior of the constructor and shouldn't be changed. Consider adding a separate test for the singleton instead.
It depends. Unit tests explicitly there to validate the behavior of the constructor shouldn't be changed, whereas it would be beneficial to update product code that defines its own singletons in lieu of a centrally defined one. |
src/libraries/System.Text.Json/src/System/Text/Json/Serialization/JsonSerializerOptions.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Text.Json/tests/System.Text.Json.Tests/Serialization/OptionsTests.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Text.Json/src/System/Text/Json/Serialization/JsonSerializerOptions.cs
Outdated
Show resolved
Hide resolved
|
@I-SER-I would it be possible to address the feedback when possible? Thanks! |
…th JsonSerializerDefaults and add tests
adf3c1e to
0d679d0
Compare
Close #92181