Add JSON null support for the built-in (ReadOnly)Memory converters.#95275
Add JSON null support for the built-in (ReadOnly)Memory converters.#95275eiriktsarpalis merged 2 commits intodotnet:mainfrom
Conversation
ghost
added
the
|
Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis Issue DetailsFix #95267.
|
...System.Text.Json/src/System/Text/Json/Serialization/Converters/Collection/MemoryConverter.cs
Outdated
Show resolved
Hide resolved
...ext.Json/src/System/Text/Json/Serialization/Converters/Collection/ReadOnlyMemoryConverter.cs
Outdated
Show resolved
Hide resolved
| { | ||
| ConverterStrategy = converter.ConverterStrategy; | ||
| Converter = converter; | ||
| ConverterStrategy = converter.ConverterStrategy; |
There was a problem hiding this comment.
This change adds some wiring that was being dropped so far.
There was a problem hiding this comment.
I was about to ask :) Does that mean there's another bug that was lurking and this was fixing?
There was a problem hiding this comment.
Correct, it was surfaced with the newly added tests.
There was a problem hiding this comment.
For context this is a converter wrapper type that is being used by the source generator APIs. The logic I just added was copied from a similar wrapper type being used internally:
...ext.Json/src/System/Text/Json/Serialization/Converters/Collection/ReadOnlyMemoryConverter.cs
Show resolved
Hide resolved
|
Should this be backported to 8.0.x? |
|
/backport to release/8.0-staging |
|
Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/7019012556 |
4 participants
Fix #95267.