[wasi] Add AOT option to existing Wasi.Build.Tests#95281
[wasi] Add AOT option to existing Wasi.Build.Tests#95281ilonatommy merged 25 commits intodotnet:mainfrom
Conversation
|
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsContributes to #95136. To prevent the situation when we have too many tests in one file, the tests got sorted by most important actions executed on them: build, publish and run. The simple program was moved to assets. AOT + single file bundle fails - #95273
|
|
This is difficult to review because:
Could you please separate the two into separate PRs? I think maybe even avoid moving tests around to new files just for avoiding |
|
Another test to add - project file has |
I am not sure I understand the need to have a test with only build inside. Isn't it covered by e.g. |
radical
left a comment
There was a problem hiding this comment.
LGTM! Thank you for the cleanup, and the new tests.
|
FYI: I'm working on a build-related PR which will add more tests, and another one that updates wasi.build.tests to use the recent Provider infrastructure. I will rebase my changes to include this one, but till those PRs land I would suggest avoiding the wasi.build.tests . |
|
I don't understand why the timeouts still occur. Locally: |
|
The problem seems to be that all the wasi.build.tests are running for each helix item. For runtime/src/libraries/sendtohelix-wasm.targets Lines 287 to 323 in 2f5cf1c src/libraries/sendtohelix-wasi.targets needs the same test splitting based on test class names. The target should be shareable with a few changes.
Update: that's at least one problem. Another is that all of them are running in parallel, but that will go away once we have one test class per helix item. |
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributes to #95136.
AOT + single file bundle fails - #95273
When we just publish and run, AOT works fine in both single file bundle and without it.