[wasm/wasi] WBT: Avoid workload integrity checks on helix#95941
Merged
radical merged 2 commits intodotnet:mainfrom Dec 13, 2023
Merged
[wasm/wasi] WBT: Avoid workload integrity checks on helix#95941radical merged 2 commits intodotnet:mainfrom
radical merged 2 commits intodotnet:mainfrom
Conversation
…sendtohelix-wasm.targets
… and DOTNET_SKIP_FIRST_TIME_EXPERIENCE=1 for wbt
|
Tagging subscribers to 'arch-wasm': @lewing Issue Details
TODO:
|
ilonatommy
approved these changes
Dec 13, 2023
Member
ilonatommy
left a comment
There was a problem hiding this comment.
"instead run this on build machine itself" in this PR we don't force this step. Is the check already switched on, on the build machines, so that no changes are required?
Member
Author
I have updated the test. We are not doing that in this PR. I need to check how we could trigger the workload integrity check for sure, as it depends on the sentinel file too which is in user config directory. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first test in WBT run on windows can some times timeout because
dotnetruns a workload integrity check before the build, adding to the time taken by the project.At install time on the build machine, we run
dotnet workload listwhich should do the first use checks, but IIUC, the sentinel is checked in user profile directory, and thus is dependent on the helix machine. Instead, avoid that on helix.Fixes #94821 .