Skip to content

Comments

Revert #96609#97407

Merged
amanasifkhalid merged 1 commit intodotnet:mainfrom
amanasifkhalid:revert
Jan 23, 2024
Merged

Revert #96609#97407
amanasifkhalid merged 1 commit intodotnet:mainfrom
amanasifkhalid:revert

Conversation

@amanasifkhalid
Copy link
Contributor

@amanasifkhalid amanasifkhalid commented Jan 23, 2024

This reverts "JIT: Allow BBJ_COND false target to diverge from bbNext in layout optimization phase" (commit 5598dac). See #97399 for discussion.

cc @dotnet/jit-contrib, @AndyAyersMS @stephentoub PTAL.

@ghost ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jan 23, 2024
@ghost ghost assigned amanasifkhalid Jan 23, 2024
@ghost
Copy link

ghost commented Jan 23, 2024

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

This reverts "JIT: Allow BBJ_COND false target to diverge from bbNext in layout optimization phase" (commit 5598dac). See #97399 for discussion.

cc @dotnet/jit-contrib, @AndyAyersMS @stephentoub PTAL.

Author: amanasifkhalid
Assignees: amanasifkhalid
Labels:

area-CodeGen-coreclr
Milestone: -

@amanasifkhalid amanasifkhalid merged commit 6f24dbc into dotnet:main Jan 23, 2024
@build-analysis build-analysis bot mentioned this pull request Jan 23, 2024
Closed
@ryujit-bot
Copy link

ryujit-bot commented Jan 24, 2024

Diff results for #97407

Assembly diffs

Assembly diffs for linux/arm64 ran on windows/x64

Diffs are based on 2,501,157 contexts (1,003,806 MinOpts, 1,497,351 FullOpts).

MISSED contexts: base: 3,956 (0.16%), diff: 4,060 (0.16%)

Overall (+670,544 bytes)
Collection Base size (bytes) Diff size (bytes)
benchmarks.run.linux.arm64.checked.mch 15,577,276 -156
benchmarks.run_pgo.linux.arm64.checked.mch 80,907,368 +227,948
benchmarks.run_tiered.linux.arm64.checked.mch 24,708,932 +48
coreclr_tests.run.linux.arm64.checked.mch 509,787,824 +37,012
libraries.crossgen2.linux.arm64.checked.mch 55,736,420 +1,616
libraries.pmi.linux.arm64.checked.mch 75,990,012 +32,840
libraries_tests.run.linux.arm64.Release.mch 381,208,104 +242,252
libraries_tests_no_tiered_compilation.run.linux.arm64.Release.mch 162,529,068 +127,424
realworld.run.linux.arm64.checked.mch 15,905,768 +1,280
smoke_tests.nativeaot.linux.arm64.checked.mch 2,949,052 +280
FullOpts (+670,544 bytes)
Collection Base size (bytes) Diff size (bytes)
benchmarks.run.linux.arm64.checked.mch 15,274,268 -156
benchmarks.run_pgo.linux.arm64.checked.mch 55,970,908 +227,948
benchmarks.run_tiered.linux.arm64.checked.mch 4,924,076 +48
coreclr_tests.run.linux.arm64.checked.mch 160,562,768 +37,012
libraries.crossgen2.linux.arm64.checked.mch 55,734,784 +1,616
libraries.pmi.linux.arm64.checked.mch 75,870,028 +32,840
libraries_tests.run.linux.arm64.Release.mch 165,910,964 +242,252
libraries_tests_no_tiered_compilation.run.linux.arm64.Release.mch 149,047,856 +127,424
realworld.run.linux.arm64.checked.mch 15,320,400 +1,280
smoke_tests.nativeaot.linux.arm64.checked.mch 2,948,104 +280

Assembly diffs for linux/x64 ran on windows/x64

Diffs are based on 2,595,007 contexts (1,052,329 MinOpts, 1,542,678 FullOpts).

MISSED contexts: base: 3,599 (0.14%), diff: 3,628 (0.14%)

Overall (+5,892,963 bytes)
Collection Base size (bytes) Diff size (bytes)
benchmarks.run.linux.x64.checked.mch 13,734,994 +130
benchmarks.run_pgo.linux.x64.checked.mch 66,799,129 +1,835,927
benchmarks.run_tiered.linux.x64.checked.mch 17,373,065 +87
coreclr_tests.run.linux.x64.checked.mch 458,906,575 +644,503
libraries.crossgen2.linux.x64.checked.mch 38,668,470 +1,762
libraries.pmi.linux.x64.checked.mch 59,969,140 +174,992
libraries_tests.run.linux.x64.Release.mch 330,795,748 +2,763,181
libraries_tests_no_tiered_compilation.run.linux.x64.Release.mch 129,997,542 +470,821
realworld.run.linux.x64.checked.mch 13,193,410 +1,198
smoke_tests.nativeaot.linux.x64.checked.mch 4,197,804 +362
FullOpts (+5,892,963 bytes)
Collection Base size (bytes) Diff size (bytes)
benchmarks.run.linux.x64.checked.mch 13,468,201 +130
benchmarks.run_pgo.linux.x64.checked.mch 46,969,372 +1,835,927
benchmarks.run_tiered.linux.x64.checked.mch 3,695,305 +87
coreclr_tests.run.linux.x64.checked.mch 132,348,440 +644,503
libraries.crossgen2.linux.x64.checked.mch 38,667,268 +1,762
libraries.pmi.linux.x64.checked.mch 59,856,270 +174,992
libraries_tests.run.linux.x64.Release.mch 146,406,227 +2,763,181
libraries_tests_no_tiered_compilation.run.linux.x64.Release.mch 119,339,071 +470,821
realworld.run.linux.x64.checked.mch 12,804,304 +1,198
smoke_tests.nativeaot.linux.x64.checked.mch 4,196,893 +362

Assembly diffs for osx/arm64 ran on windows/x64

Diffs are based on 2,262,709 contexts (930,876 MinOpts, 1,331,833 FullOpts).

MISSED contexts: base: 3,201 (0.14%), diff: 3,256 (0.14%)

Overall (+444,156 bytes)
Collection Base size (bytes) Diff size (bytes)
benchmarks.run.osx.arm64.checked.mch 11,178,424 -64
benchmarks.run_pgo.osx.arm64.checked.mch 34,559,052 +112,220
benchmarks.run_tiered.osx.arm64.checked.mch 15,557,856 +32
coreclr_tests.run.osx.arm64.checked.mch 485,344,932 +36,308
libraries.crossgen2.osx.arm64.checked.mch 55,620,496 +1,608
libraries.pmi.osx.arm64.checked.mch 79,954,588 +888
libraries_tests.run.osx.arm64.Release.mch 312,735,908 +167,732
libraries_tests_no_tiered_compilation.run.osx.arm64.Release.mch 160,786,940 +124,140
realworld.run.osx.arm64.checked.mch 15,071,220 +1,292
FullOpts (+444,156 bytes)
Collection Base size (bytes) Diff size (bytes)
benchmarks.run.osx.arm64.checked.mch 11,177,888 -64
benchmarks.run_pgo.osx.arm64.checked.mch 18,085,772 +112,220
benchmarks.run_tiered.osx.arm64.checked.mch 4,042,780 +32
coreclr_tests.run.osx.arm64.checked.mch 153,038,476 +36,308
libraries.crossgen2.osx.arm64.checked.mch 55,618,868 +1,608
libraries.pmi.osx.arm64.checked.mch 79,833,460 +888
libraries_tests.run.osx.arm64.Release.mch 108,795,404 +167,732
libraries_tests_no_tiered_compilation.run.osx.arm64.Release.mch 147,649,412 +124,140
realworld.run.osx.arm64.checked.mch 14,502,816 +1,292

Assembly diffs for windows/arm64 ran on windows/x64

Diffs are based on 2,318,207 contexts (931,543 MinOpts, 1,386,664 FullOpts).

MISSED contexts: base: 2,601 (0.11%), diff: 2,687 (0.12%)

Overall (+521,152 bytes)
Collection Base size (bytes) Diff size (bytes)
benchmarks.run.windows.arm64.checked.mch 10,961,376 -140
benchmarks.run_pgo.windows.arm64.checked.mch 47,210,356 +184,268
benchmarks.run_tiered.windows.arm64.checked.mch 15,343,876 -36
coreclr_tests.run.windows.arm64.checked.mch 495,343,368 +28,728
libraries.crossgen2.windows.arm64.checked.mch 58,963,136 +1,644
libraries.pmi.windows.arm64.checked.mch 79,562,880 +31,844
libraries_tests.run.windows.arm64.Release.mch 310,370,552 +140,708
libraries_tests_no_tiered_compilation.run.windows.arm64.Release.mch 169,001,944 +132,408
realworld.run.windows.arm64.checked.mch 15,889,988 +1,272
smoke_tests.nativeaot.windows.arm64.checked.mch 3,972,708 +456
FullOpts (+521,152 bytes)
Collection Base size (bytes) Diff size (bytes)
benchmarks.run.windows.arm64.checked.mch 10,960,840 -140
benchmarks.run_pgo.windows.arm64.checked.mch 30,959,972 +184,268
benchmarks.run_tiered.windows.arm64.checked.mch 4,154,500 -36
coreclr_tests.run.windows.arm64.checked.mch 156,251,840 +28,728
libraries.crossgen2.windows.arm64.checked.mch 58,961,500 +1,644
libraries.pmi.windows.arm64.checked.mch 79,442,896 +31,844
libraries_tests.run.windows.arm64.Release.mch 108,789,048 +140,708
libraries_tests_no_tiered_compilation.run.windows.arm64.Release.mch 155,864,480 +132,408
realworld.run.windows.arm64.checked.mch 15,321,564 +1,272
smoke_tests.nativeaot.windows.arm64.checked.mch 3,971,736 +456

Assembly diffs for windows/x64 ran on windows/x64

Diffs are based on 2,492,912 contexts (983,689 MinOpts, 1,509,223 FullOpts).

MISSED contexts: base: 3,862 (0.15%), diff: 3,899 (0.16%)

Overall (+4,026,349 bytes)
Collection Base size (bytes) Diff size (bytes)
aspnet.run.windows.x64.checked.mch 41,787,647 +391,910
benchmarks.run.windows.x64.checked.mch 8,747,647 -77
benchmarks.run_pgo.windows.x64.checked.mch 34,738,461 +652,832
benchmarks.run_tiered.windows.x64.checked.mch 12,661,708 -210
coreclr_tests.run.windows.x64.checked.mch 392,888,034 +516,889
libraries.crossgen2.windows.x64.checked.mch 39,442,225 +1,697
libraries.pmi.windows.x64.checked.mch 61,193,053 +196,137
libraries_tests.run.windows.x64.Release.mch 279,857,552 +1,784,757
libraries_tests_no_tiered_compilation.run.windows.x64.Release.mch 133,433,111 +481,035
realworld.run.windows.x64.checked.mch 14,169,724 +1,032
smoke_tests.nativeaot.windows.x64.checked.mch 5,092,017 +347
FullOpts (+4,026,349 bytes)
Collection Base size (bytes) Diff size (bytes)
aspnet.run.windows.x64.checked.mch 27,128,922 +391,910
benchmarks.run.windows.x64.checked.mch 8,747,286 -77
benchmarks.run_pgo.windows.x64.checked.mch 20,503,484 +652,832
benchmarks.run_tiered.windows.x64.checked.mch 3,476,442 -210
coreclr_tests.run.windows.x64.checked.mch 119,345,042 +516,889
libraries.crossgen2.windows.x64.checked.mch 39,441,036 +1,697
libraries.pmi.windows.x64.checked.mch 61,079,534 +196,137
libraries_tests.run.windows.x64.Release.mch 101,489,236 +1,784,757
libraries_tests_no_tiered_compilation.run.windows.x64.Release.mch 123,009,741 +481,035
realworld.run.windows.x64.checked.mch 13,780,019 +1,032
smoke_tests.nativeaot.windows.x64.checked.mch 5,091,108 +347

Details here

Assembly diffs for linux/arm ran on windows/x86

Diffs are based on 2,237,690 contexts (827,812 MinOpts, 1,409,878 FullOpts).

MISSED contexts: base: 74,543 (3.22%), diff: 74,588 (3.23%)

Overall (+2,317,030 bytes)
Collection Base size (bytes) Diff size (bytes)
benchmarks.run.linux.arm.checked.mch 15,302,516 +618
benchmarks.run_pgo.linux.arm.checked.mch 60,229,150 +1,032,978
benchmarks.run_tiered.linux.arm.checked.mch 22,642,948 +500
coreclr_tests.run.linux.arm.checked.mch 321,630,692 +160,424
libraries.crossgen2.linux.arm.checked.mch 35,174,564 +698
libraries.pmi.linux.arm.checked.mch 49,549,994 +65,952
libraries_tests.run.linux.arm.Release.mch 241,868,412 +893,708
libraries_tests_no_tiered_compilation.run.linux.arm.Release.mch 93,040,820 +160,792
realworld.run.linux.arm.checked.mch 13,612,086 +1,360
FullOpts (+2,317,030 bytes)
Collection Base size (bytes) Diff size (bytes)
benchmarks.run.linux.arm.checked.mch 14,913,260 +618
benchmarks.run_pgo.linux.arm.checked.mch 49,431,548 +1,032,978
benchmarks.run_tiered.linux.arm.checked.mch 13,535,792 +500
coreclr_tests.run.linux.arm.checked.mch 108,900,558 +160,424
libraries.crossgen2.linux.arm.checked.mch 35,173,334 +698
libraries.pmi.linux.arm.checked.mch 49,443,490 +65,952
libraries_tests.run.linux.arm.Release.mch 119,865,468 +893,708
libraries_tests_no_tiered_compilation.run.linux.arm.Release.mch 82,957,000 +160,792
realworld.run.linux.arm.checked.mch 13,162,140 +1,360

Assembly diffs for windows/x86 ran on windows/x86

Diffs are based on 2,296,250 contexts (841,817 MinOpts, 1,454,433 FullOpts).

MISSED contexts: base: 2,552 (0.11%), diff: 5,093 (0.22%)

Overall (+4,485,904 bytes)
Collection Base size (bytes) Diff size (bytes)
benchmarks.run.windows.x86.checked.mch 7,107,340 +147
benchmarks.run_pgo.windows.x86.checked.mch 43,402,092 +1,820,454
benchmarks.run_tiered.windows.x86.checked.mch 9,511,225 +235
coreclr_tests.run.windows.x86.checked.mch 308,523,712 +656,768
libraries.crossgen2.windows.x86.checked.mch 31,626,935 +1,363
libraries.pmi.windows.x86.checked.mch 48,679,731 +148,189
libraries_tests.run.windows.x86.Release.mch 184,050,709 +1,497,619
libraries_tests_no_tiered_compilation.run.windows.x86.Release.mch 101,838,360 +359,849
realworld.run.windows.x86.checked.mch 11,362,130 +1,280
FullOpts (+4,485,904 bytes)
Collection Base size (bytes) Diff size (bytes)
benchmarks.run.windows.x86.checked.mch 7,107,061 +147
benchmarks.run_pgo.windows.x86.checked.mch 36,772,602 +1,820,454
benchmarks.run_tiered.windows.x86.checked.mch 5,241,416 +235
coreclr_tests.run.windows.x86.checked.mch 106,851,943 +656,768
libraries.crossgen2.windows.x86.checked.mch 31,625,878 +1,363
libraries.pmi.windows.x86.checked.mch 48,584,417 +148,189
libraries_tests.run.windows.x86.Release.mch 85,719,202 +1,497,619
libraries_tests_no_tiered_compilation.run.windows.x86.Release.mch 93,168,568 +359,849
realworld.run.windows.x86.checked.mch 11,066,430 +1,280

Details here

Throughput diffs

Throughput diffs for linux/arm64 ran on windows/x64

Overall (-0.02% to +0.45%)
Collection PDIFF
benchmarks.run.linux.arm64.checked.mch -0.02%
benchmarks.run_pgo.linux.arm64.checked.mch +0.45%
benchmarks.run_tiered.linux.arm64.checked.mch -0.01%
coreclr_tests.run.linux.arm64.checked.mch +0.03%
libraries.crossgen2.linux.arm64.checked.mch -0.01%
libraries.pmi.linux.arm64.checked.mch +0.07%
libraries_tests.run.linux.arm64.Release.mch +0.22%
libraries_tests_no_tiered_compilation.run.linux.arm64.Release.mch +0.08%
realworld.run.linux.arm64.checked.mch -0.01%
smoke_tests.nativeaot.linux.arm64.checked.mch -0.02%
FullOpts (-0.02% to +0.51%)
Collection PDIFF
benchmarks.run.linux.arm64.checked.mch -0.02%
benchmarks.run_pgo.linux.arm64.checked.mch +0.51%
benchmarks.run_tiered.linux.arm64.checked.mch -0.02%
coreclr_tests.run.linux.arm64.checked.mch +0.05%
libraries.crossgen2.linux.arm64.checked.mch -0.01%
libraries.pmi.linux.arm64.checked.mch +0.07%
libraries_tests.run.linux.arm64.Release.mch +0.30%
libraries_tests_no_tiered_compilation.run.linux.arm64.Release.mch +0.08%
realworld.run.linux.arm64.checked.mch -0.01%
smoke_tests.nativeaot.linux.arm64.checked.mch -0.02%

Throughput diffs for linux/x64 ran on windows/x64

Overall (-0.03% to +0.56%)
Collection PDIFF
benchmarks.run.linux.x64.checked.mch -0.02%
benchmarks.run_pgo.linux.x64.checked.mch +0.56%
benchmarks.run_tiered.linux.x64.checked.mch -0.01%
coreclr_tests.run.linux.x64.checked.mch +0.02%
libraries.crossgen2.linux.x64.checked.mch -0.01%
libraries.pmi.linux.x64.checked.mch +0.06%
libraries_tests.run.linux.x64.Release.mch +0.23%
libraries_tests_no_tiered_compilation.run.linux.x64.Release.mch +0.06%
realworld.run.linux.x64.checked.mch -0.01%
smoke_tests.nativeaot.linux.x64.checked.mch -0.03%
MinOpts (-0.00% to +0.01%)
Collection PDIFF
libraries.pmi.linux.x64.checked.mch +0.01%
realworld.run.linux.x64.checked.mch +0.01%
FullOpts (-0.03% to +0.61%)
Collection PDIFF
benchmarks.run.linux.x64.checked.mch -0.02%
benchmarks.run_pgo.linux.x64.checked.mch +0.61%
benchmarks.run_tiered.linux.x64.checked.mch -0.02%
coreclr_tests.run.linux.x64.checked.mch +0.04%
libraries.crossgen2.linux.x64.checked.mch -0.01%
libraries.pmi.linux.x64.checked.mch +0.06%
libraries_tests.run.linux.x64.Release.mch +0.30%
libraries_tests_no_tiered_compilation.run.linux.x64.Release.mch +0.06%
realworld.run.linux.x64.checked.mch -0.01%
smoke_tests.nativeaot.linux.x64.checked.mch -0.03%

Throughput diffs for osx/arm64 ran on windows/x64

Overall (-0.02% to +0.43%)
Collection PDIFF
benchmarks.run.osx.arm64.checked.mch -0.01%
benchmarks.run_pgo.osx.arm64.checked.mch +0.43%
benchmarks.run_tiered.osx.arm64.checked.mch -0.01%
coreclr_tests.run.osx.arm64.checked.mch +0.02%
libraries.crossgen2.osx.arm64.checked.mch -0.01%
libraries.pmi.osx.arm64.checked.mch -0.02%
libraries_tests.run.osx.arm64.Release.mch +0.23%
libraries_tests_no_tiered_compilation.run.osx.arm64.Release.mch +0.08%
realworld.run.osx.arm64.checked.mch -0.01%
FullOpts (-0.02% to +0.53%)
Collection PDIFF
benchmarks.run.osx.arm64.checked.mch -0.01%
benchmarks.run_pgo.osx.arm64.checked.mch +0.53%
benchmarks.run_tiered.osx.arm64.checked.mch -0.02%
coreclr_tests.run.osx.arm64.checked.mch +0.04%
libraries.crossgen2.osx.arm64.checked.mch -0.01%
libraries.pmi.osx.arm64.checked.mch -0.02%
libraries_tests.run.osx.arm64.Release.mch +0.35%
libraries_tests_no_tiered_compilation.run.osx.arm64.Release.mch +0.09%
realworld.run.osx.arm64.checked.mch -0.01%

Throughput diffs for windows/arm64 ran on windows/x64

Overall (-0.02% to +0.49%)
Collection PDIFF
benchmarks.run.windows.arm64.checked.mch -0.01%
benchmarks.run_pgo.windows.arm64.checked.mch +0.49%
benchmarks.run_tiered.windows.arm64.checked.mch -0.01%
coreclr_tests.run.windows.arm64.checked.mch +0.02%
libraries.crossgen2.windows.arm64.checked.mch -0.01%
libraries.pmi.windows.arm64.checked.mch +0.07%
libraries_tests.run.windows.arm64.Release.mch +0.21%
libraries_tests_no_tiered_compilation.run.windows.arm64.Release.mch +0.09%
realworld.run.windows.arm64.checked.mch -0.01%
smoke_tests.nativeaot.windows.arm64.checked.mch -0.02%
FullOpts (-0.02% to +0.56%)
Collection PDIFF
benchmarks.run.windows.arm64.checked.mch -0.01%
benchmarks.run_pgo.windows.arm64.checked.mch +0.56%
benchmarks.run_tiered.windows.arm64.checked.mch -0.02%
coreclr_tests.run.windows.arm64.checked.mch +0.03%
libraries.crossgen2.windows.arm64.checked.mch -0.01%
libraries.pmi.windows.arm64.checked.mch +0.07%
libraries_tests.run.windows.arm64.Release.mch +0.31%
libraries_tests_no_tiered_compilation.run.windows.arm64.Release.mch +0.09%
realworld.run.windows.arm64.checked.mch -0.01%
smoke_tests.nativeaot.windows.arm64.checked.mch -0.02%

Throughput diffs for windows/x64 ran on windows/x64

Overall (-0.03% to +0.55%)
Collection PDIFF
aspnet.run.windows.x64.checked.mch +0.22%
benchmarks.run.windows.x64.checked.mch -0.02%
benchmarks.run_pgo.windows.x64.checked.mch +0.55%
benchmarks.run_tiered.windows.x64.checked.mch -0.01%
coreclr_tests.run.windows.x64.checked.mch +0.02%
libraries.crossgen2.windows.x64.checked.mch -0.01%
libraries.pmi.windows.x64.checked.mch +0.05%
libraries_tests.run.windows.x64.Release.mch +0.21%
libraries_tests_no_tiered_compilation.run.windows.x64.Release.mch +0.05%
realworld.run.windows.x64.checked.mch -0.01%
smoke_tests.nativeaot.windows.x64.checked.mch -0.03%
MinOpts (-0.00% to +0.01%)
Collection PDIFF
libraries.pmi.windows.x64.checked.mch +0.01%
realworld.run.windows.x64.checked.mch +0.01%
FullOpts (-0.03% to +0.64%)
Collection PDIFF
aspnet.run.windows.x64.checked.mch +0.25%
benchmarks.run.windows.x64.checked.mch -0.02%
benchmarks.run_pgo.windows.x64.checked.mch +0.64%
benchmarks.run_tiered.windows.x64.checked.mch -0.02%
coreclr_tests.run.windows.x64.checked.mch +0.03%
libraries.crossgen2.windows.x64.checked.mch -0.01%
libraries.pmi.windows.x64.checked.mch +0.05%
libraries_tests.run.windows.x64.Release.mch +0.30%
libraries_tests_no_tiered_compilation.run.windows.x64.Release.mch +0.06%
realworld.run.windows.x64.checked.mch -0.01%
smoke_tests.nativeaot.windows.x64.checked.mch -0.03%

Details here

Throughput diffs for linux/arm ran on windows/x86

Overall (+0.02% to +0.19%)
Collection PDIFF
benchmarks.run.linux.arm.checked.mch +0.02%
benchmarks.run_pgo.linux.arm.checked.mch +0.17%
benchmarks.run_tiered.linux.arm.checked.mch +0.02%
coreclr_tests.run.linux.arm.checked.mch +0.04%
libraries.crossgen2.linux.arm.checked.mch +0.02%
libraries.pmi.linux.arm.checked.mch +0.16%
libraries_tests.run.linux.arm.Release.mch +0.19%
libraries_tests_no_tiered_compilation.run.linux.arm.Release.mch +0.14%
realworld.run.linux.arm.checked.mch +0.02%
MinOpts (+0.00% to +0.02%)
Collection PDIFF
benchmarks.run_pgo.linux.arm.checked.mch +0.01%
benchmarks.run_tiered.linux.arm.checked.mch +0.01%
coreclr_tests.run.linux.arm.checked.mch +0.01%
libraries.crossgen2.linux.arm.checked.mch +0.01%
libraries.pmi.linux.arm.checked.mch +0.02%
libraries_tests_no_tiered_compilation.run.linux.arm.Release.mch +0.01%
realworld.run.linux.arm.checked.mch +0.01%
FullOpts (+0.02% to +0.24%)
Collection PDIFF
benchmarks.run.linux.arm.checked.mch +0.02%
benchmarks.run_pgo.linux.arm.checked.mch +0.18%
benchmarks.run_tiered.linux.arm.checked.mch +0.02%
coreclr_tests.run.linux.arm.checked.mch +0.07%
libraries.crossgen2.linux.arm.checked.mch +0.02%
libraries.pmi.linux.arm.checked.mch +0.16%
libraries_tests.run.linux.arm.Release.mch +0.24%
libraries_tests_no_tiered_compilation.run.linux.arm.Release.mch +0.15%
realworld.run.linux.arm.checked.mch +0.02%

Throughput diffs for windows/x86 ran on windows/x86

Overall (-0.19% to +0.18%)
Collection PDIFF
benchmarks.run.windows.x86.checked.mch +0.04%
benchmarks.run_pgo.windows.x86.checked.mch -0.19%
benchmarks.run_tiered.windows.x86.checked.mch +0.04%
coreclr_tests.run.windows.x86.checked.mch +0.05%
libraries.crossgen2.windows.x86.checked.mch +0.03%
libraries.pmi.windows.x86.checked.mch +0.13%
libraries_tests.run.windows.x86.Release.mch +0.18%
libraries_tests_no_tiered_compilation.run.windows.x86.Release.mch +0.10%
realworld.run.windows.x86.checked.mch +0.04%
MinOpts (+0.01% to +0.05%)
Collection PDIFF
benchmarks.run.windows.x86.checked.mch +0.01%
benchmarks.run_pgo.windows.x86.checked.mch +0.02%
benchmarks.run_tiered.windows.x86.checked.mch +0.02%
coreclr_tests.run.windows.x86.checked.mch +0.01%
libraries.crossgen2.windows.x86.checked.mch +0.02%
libraries.pmi.windows.x86.checked.mch +0.05%
libraries_tests.run.windows.x86.Release.mch +0.01%
libraries_tests_no_tiered_compilation.run.windows.x86.Release.mch +0.02%
realworld.run.windows.x86.checked.mch +0.03%
FullOpts (-0.20% to +0.22%)
Collection PDIFF
benchmarks.run.windows.x86.checked.mch +0.04%
benchmarks.run_pgo.windows.x86.checked.mch -0.20%
benchmarks.run_tiered.windows.x86.checked.mch +0.04%
coreclr_tests.run.windows.x86.checked.mch +0.07%
libraries.crossgen2.windows.x86.checked.mch +0.03%
libraries.pmi.windows.x86.checked.mch +0.13%
libraries_tests.run.windows.x86.Release.mch +0.22%
libraries_tests_no_tiered_compilation.run.windows.x86.Release.mch +0.10%
realworld.run.windows.x86.checked.mch +0.04%

Details here

Throughput diffs for linux/arm64 ran on linux/x64

Overall (+0.02% to +0.58%)
Collection PDIFF
benchmarks.run_tiered.linux.arm64.checked.mch +0.02%
libraries.crossgen2.linux.arm64.checked.mch +0.04%
libraries_tests.run.linux.arm64.Release.mch +0.29%
benchmarks.run.linux.arm64.checked.mch +0.05%
benchmarks.run_pgo.linux.arm64.checked.mch +0.58%
coreclr_tests.run.linux.arm64.checked.mch +0.04%
libraries_tests_no_tiered_compilation.run.linux.arm64.Release.mch +0.13%
realworld.run.linux.arm64.checked.mch +0.05%
smoke_tests.nativeaot.linux.arm64.checked.mch +0.05%
libraries.pmi.linux.arm64.checked.mch +0.12%
MinOpts (-0.04% to -0.00%)
Collection PDIFF
benchmarks.run_tiered.linux.arm64.checked.mch -0.01%
libraries_tests.run.linux.arm64.Release.mch -0.01%
benchmarks.run_pgo.linux.arm64.checked.mch -0.01%
coreclr_tests.run.linux.arm64.checked.mch -0.01%
libraries_tests_no_tiered_compilation.run.linux.arm64.Release.mch -0.02%
realworld.run.linux.arm64.checked.mch -0.01%
smoke_tests.nativeaot.linux.arm64.checked.mch -0.03%
libraries.pmi.linux.arm64.checked.mch -0.04%
FullOpts (+0.04% to +0.65%)
Collection PDIFF
benchmarks.run_tiered.linux.arm64.checked.mch +0.07%
libraries.crossgen2.linux.arm64.checked.mch +0.04%
libraries_tests.run.linux.arm64.Release.mch +0.39%
benchmarks.run.linux.arm64.checked.mch +0.05%
benchmarks.run_pgo.linux.arm64.checked.mch +0.65%
coreclr_tests.run.linux.arm64.checked.mch +0.09%
libraries_tests_no_tiered_compilation.run.linux.arm64.Release.mch +0.13%
realworld.run.linux.arm64.checked.mch +0.05%
smoke_tests.nativeaot.linux.arm64.checked.mch +0.05%
libraries.pmi.linux.arm64.checked.mch +0.12%

Throughput diffs for linux/x64 ran on linux/x64

Overall (+0.04% to +0.72%)
Collection PDIFF
libraries.pmi.linux.x64.checked.mch +0.12%
smoke_tests.nativeaot.linux.x64.checked.mch +0.06%
coreclr_tests.run.linux.x64.checked.mch +0.05%
libraries.crossgen2.linux.x64.checked.mch +0.05%
libraries_tests.run.linux.x64.Release.mch +0.31%
libraries_tests_no_tiered_compilation.run.linux.x64.Release.mch +0.12%
realworld.run.linux.x64.checked.mch +0.06%
benchmarks.run_pgo.linux.x64.checked.mch +0.72%
benchmarks.run.linux.x64.checked.mch +0.06%
benchmarks.run_tiered.linux.x64.checked.mch +0.04%
FullOpts (+0.05% to +0.79%)
Collection PDIFF
libraries.pmi.linux.x64.checked.mch +0.12%
smoke_tests.nativeaot.linux.x64.checked.mch +0.06%
coreclr_tests.run.linux.x64.checked.mch +0.09%
libraries.crossgen2.linux.x64.checked.mch +0.05%
libraries_tests.run.linux.x64.Release.mch +0.41%
libraries_tests_no_tiered_compilation.run.linux.x64.Release.mch +0.12%
realworld.run.linux.x64.checked.mch +0.06%
benchmarks.run_pgo.linux.x64.checked.mch +0.79%
benchmarks.run.linux.x64.checked.mch +0.06%
benchmarks.run_tiered.linux.x64.checked.mch +0.08%

Details here

@AndyAyersMS
Copy link
Member

AndyAyersMS commented Jan 24, 2024

Sample lab data showing regression is gone:

image

And ASP.NET:

image

@amanasifkhalid amanasifkhalid deleted the revert branch January 24, 2024 16:04
This was referenced Jan 24, 2024
Closed
Merged
This was referenced Feb 1, 2024
Closed
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@AndyAyersMS AndyAyersMS AndyAyersMS approved these changes

Assignees

@amanasifkhalid amanasifkhalid

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@amanasifkhalid @ryujit-bot @AndyAyersMS