Skip to content

Comments

[wasm] Unblock WBT that are not hanging anymore#97764

Merged
ilonatommy merged 4 commits intodotnet:mainfrom
ilonatommy:fix-97054
Feb 2, 2024
Merged

[wasm] Unblock WBT that are not hanging anymore#97764
ilonatommy merged 4 commits intodotnet:mainfrom
ilonatommy:fix-97054

Conversation

@ilonatommy
Copy link
Member

@ilonatommy ilonatommy commented Jan 31, 2024 •
edited
Loading

Fixes #97054. Unblocks tests that are passing when tested locally.

After temporarily reverting the changes in .yml files, to restore parallel runs, the CI still does not fail.

@ilonatommy ilonatommy added arch-wasm WebAssembly architecture area-Build-mono labels Jan 31, 2024
@ilonatommy ilonatommy requested a review from radical January 31, 2024 13:13
@ilonatommy ilonatommy self-assigned this Jan 31, 2024
@ilonatommy ilonatommy requested a review from maraf as a code owner January 31, 2024 13:13
@ghost
Copy link

ghost commented Jan 31, 2024

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #97054.

When we are killing await completionTask; already got processed, so it's safe. Because it's a blazor dotnet run project process, it does not get killed nicely on Process.CloseMainWindow(), we have to use Kill.

It is a blocker for #97085.

Author: ilonatommy
Assignees: ilonatommy
Labels:

arch-wasm, area-Build-mono
Milestone: -

pavelsavara
pavelsavara reviewed Jan 31, 2024
View reviewed changes
@ilonatommy ilonatommy added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Feb 1, 2024
This was referenced Feb 1, 2024
Closed
Closed
Open
Closed
@ilonatommy ilonatommy removed the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Feb 2, 2024
@ilonatommy ilonatommy changed the title [wasm] Fix hanging on subsequent dotnet new [wasm] Unblock WBT that are not hanging anymore Feb 2, 2024
@ilonatommy ilonatommy merged commit 693a224 into dotnet:main Feb 2, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Mar 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@pavelsavara pavelsavara pavelsavara approved these changes

@radical radical Awaiting requested review from radical

@maraf maraf Awaiting requested review from maraf maraf is a code owner

@akoeplinger akoeplinger Awaiting requested review from akoeplinger

@lewing lewing Awaiting requested review from lewing

Assignees

@ilonatommy ilonatommy

Labels

arch-wasm WebAssembly architecture area-Build-mono

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[wasm] WBT tests using BrowserRunner seem to hang on a subsequent dotnet new

4 participants

@ilonatommy @radical @lewing @pavelsavara