Add missing test case for BitCast#97983
Merged
tannergooding merged 1 commit intodotnet:mainfrom Feb 10, 2024
Merged
Conversation
BitCast lacked a test for the case of 2 structs with target requiring higher alignment than source, which could be problematic on platforms without unaligned loads.
ghost
added
needs-area-label
filipnavara
added
area-System.Runtime
and removed
needs-area-label
|
Tagging subscribers to this area: @dotnet/area-system-runtime Issue DetailsBitCast lacked a test for the case of 2 structs with target requiring higher alignment than source, which could be problematic on platforms without unaligned loads.
|
tannergooding
approved these changes
Feb 5, 2024
tannergooding
added a commit
to tannergooding/runtime
that referenced
this pull request
Feb 10, 2024
This reverts commit af53dab.
tannergooding
added a commit
that referenced
this pull request
Feb 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BitCast lacked a test for the case of 2 structs with target requiring higher alignment than source, which could be problematic on platforms without unaligned loads.