ActivatorUtilities.CreateInstance() should respect [ActivatorUtilitiesConstructor]

[steveharter]

The current approach of selecting constructors uses [ActivatorUtilitiesConstructor] in an odd manner that even when a constructor has the attribute, it may not be called depending on the ordering of constructors and the number of constructor parameters. This PR changes to always call the constructor that has that attribute.

Current approach:

1. Reads constructors in order declared (according to the compiler and the order metadata was written).
2. Picks the constructor with the most parameters.
3. If there is a constructor with [ActivatorUtilitiesConstructor] then that constructor is selected, no matter how many parameters are present. Only one constructor can have the attribute.
4. If there is another constructor with the same or more parameters after [ActivatorUtilitiesConstructor] was found, then that is selected.

Proposed approach: from the current approach above, remove (4) which makes (1) no longer applicable.

This address a case from #98959 where ordering of the constructors can cause a constructor that has [ActivatorUtilitiesConstructor] to not be selected if comes before a different constructor with the same parameter count, and also fully addresses the issues raised in #42339 (comment).

cc @tarekgh, @eerhardt

[ghost]

Tagging subscribers to this area: @dotnet/area-extensions-dependencyinjection
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Address a case from #98959 where ordering of the constructors can cause a constructor that has [ActivatorUtilitiesConstructor] to not be selected if comes before a different constructor with the same parameter count.

cc @tarekgh, @eerhardt

Author:	steveharter
Assignees:	steveharter
Labels:	area-Extensions-DependencyInjection
Milestone:	-

[tarekgh]

LGTM, I hope the breaking change will not cause any issue. At least now we are behaving as our docs describe.