Implement Swift lowering algorithm in the CoreCLR type system#99438
Merged
jkoritzinsky merged 14 commits intodotnet:mainfrom Mar 12, 2024
Merged
Implement Swift lowering algorithm in the CoreCLR type system#99438jkoritzinsky merged 14 commits intodotnet:mainfrom
jkoritzinsky merged 14 commits intodotnet:mainfrom
Conversation
…s of non-opaque types and to merge opaque intervals
jakobbotsch
approved these changes
Mar 8, 2024
Member
jakobbotsch
left a comment
jakobbotsch
left a comment
There was a problem hiding this comment.
LGTM, but you may want to get review from someone more familiar with the VM side.
Member
Author
|
I've added a small fix here for the NativeAOT implementation that we discussed offline. |
42 tasks
AaronRobinsonMSFT
approved these changes
Mar 11, 2024
Member
AaronRobinsonMSFT
left a comment
AaronRobinsonMSFT
left a comment
There was a problem hiding this comment.
I get the statement about contract. I don't think it is all that obvious the contract or expectations here. The 4 count is used in a few places and I replaced one, but aside from the case where byReference = true the split rules aren't clear up front, which is what I normally like to see. As long as the JIT team has clear expectations on their side for the ABI I'm good.
I assume tests will come with the JIT?
This was referenced Mar 11, 2024
Member
Author
|
Yep the JIT PR will add the test suite. I'll refactor out the max size into a constant. |
AaronRobinsonMSFT
approved these changes
Mar 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR finishes out the implementations of the algorithm for RyuJIT-compatible type systems.
This does not update the JIT-EE interface to hook up the new function (@jakobbotsch has already made the JIT-EE change in his branch, so I don't want to conflict with that).