JIT: Delete some unused fields in CallArgABIInformation#99972
Merged
jakobbotsch merged 1 commit intodotnet:mainfrom Mar 20, 2024
Merged
JIT: Delete some unused fields in CallArgABIInformation#99972jakobbotsch merged 1 commit intodotnet:mainfrom
CallArgABIInformation#99972jakobbotsch merged 1 commit intodotnet:mainfrom
Conversation
ghost
added
the
area-CodeGen-coreclr
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
filipnavara
reviewed
Mar 19, 2024
Comment on lines
4470
to
4472
| // Unix amd64 will split floating point types and integer types in structs | ||
| // between floating point and general purpose registers. Keep track of that | ||
| // information so we do not need to recompute it later. |
Member
There was a problem hiding this comment.
Maybe the comment should be updated too?
Member
Author
There was a problem hiding this comment.
I left it since the comment equally applies to the StructDesc that we do use in a few places.
Member
Author
|
cc @dotnet/jit-contrib, simple change No diffs. superpmi-replay failure is a timeout. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.