Wasm SDK packed as a nuget package#31519
Merged
lewing merged 31 commits intodotnet:mainfrom Apr 21, 2023
Merged
Conversation
ghost
added
49 tasks
…tests in place at the moment
…rosoftNETSdkWebAssembly to ProcessFrameworkReferences.
…ack" This reverts commit 0af6292.
Include WasmSDK Pack based on UsingMicrosoftNETSdkWebAssembly
lewing
reviewed
Apr 10, 2023
Member
lewing
left a comment
lewing
left a comment
There was a problem hiding this comment.
This is looking good, what else is left?
src/Tasks/Microsoft.NET.Build.Tasks/ProcessFrameworkReferences.cs
Outdated
Show resolved
Hide resolved
# Conflicts: # src/WasmSdk/Targets/Microsoft.NET.Sdk.WebAssembly.Current.targets
5 tasks
This reverts commit fcc5d48.
WasmSdk supports browser-wasm and wasi-wasm, but Blazor typically wants to override RID passed for server project. That is not the case for WasmSdk.
It is shared for net50 blazor. WasmSdk might turn it off to support different RIDs.
It is shared for net50 blazor.
Member
|
@rainersigwald @tmat @mthalman I'm having a little trouble following all the flow here but are we expecting the failures here to be resolved once everthing flows? dotnet/sourcelink#1007 |
Member
|
@lewing I think so. |
…0230421.2 Microsoft.Build.Tasks.Git , Microsoft.SourceLink.AzureRepos.Git , Microsoft.SourceLink.Bitbucket.Git , Microsoft.SourceLink.Common , Microsoft.SourceLink.GitHub , Microsoft.SourceLink.GitLab From Version 8.0.0-beta.23210.3 -> To Version 8.0.0-beta.23221.2
Member
|
triggered #31953 but also pulled the bump in here to verify |
lewing
approved these changes
Apr 21, 2023
Member
|
@javiercn @MackinnonBuck any objections? |
javiercn
approved these changes
Apr 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move bits of Wasm SDK that are expected to change more frequently to the runtime repo.
Microsoft.NET.Sdk.WebAssembly.Packimplicit package reference ifUsingMicrosoftNETSdkWebAssembly=true._WebAssemblyPropsFileand_WebAssemblyTargetsFileproperties to enable overriding props and targets.Contributes to dotnet/runtime#81367