Add AddMetricsConsumer helper to TelemetryConsumption#1899
Merged
MihaZupan merged 1 commit intodotnet:mainfrom Oct 19, 2022
Merged
Add AddMetricsConsumer helper to TelemetryConsumption#1899MihaZupan merged 1 commit intodotnet:mainfrom
MihaZupan merged 1 commit intodotnet:mainfrom
Conversation
Tratcher
approved these changes
Oct 18, 2022
| } | ||
|
|
||
| var eventLevel = enableEvents ? EventLevel.Verbose : EventLevel.Critical; | ||
| var eventLevel = enableEvents ? EventLevel.Informational : EventLevel.Critical; |
Member
Author
There was a problem hiding this comment.
This doesn't change anything currently, but it can make a significant difference if we ever add debug/trace events to the existing EventSources.
Since this library only knows about the current (informational) events, it would only waste CPU on more verbose events.
If we ever want to consume more verbose events with this library, we will adjust this flag as needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am writing networking telemetry docs and it bothered me that we have very convenient helpers for
ITelemetryConsumer*s, but nothing forIMetricsConsumer<T>.So while you can write code like this for events:
you have to write this for metrics:
or even this if you implement multiple interfaces:
This PR adds
AddMetricsConsumerhelpers that do the same for metrics asAddTelemetryConsumerdoes for events.