Make Receiver's HttpClient extensible#2043
Merged
microsoft-github-policy-service[bot] merged 5 commits intodotnet:mainfrom Feb 28, 2023
Merged
Make Receiver's HttpClient extensible#2043microsoft-github-policy-service[bot] merged 5 commits intodotnet:mainfrom
microsoft-github-policy-service[bot] merged 5 commits intodotnet:mainfrom
Conversation
Contributor
Author
|
@microsoft-github-policy-service agree |
MihaZupan
reviewed
Feb 27, 2023
Member
MihaZupan
left a comment
MihaZupan
left a comment
There was a problem hiding this comment.
Thanks for looking to contribute. I would simplify the number of properties to configure, but otherwise LGTM.
MihaZupan
approved these changes
Feb 28, 2023
MihaZupan
reviewed
Feb 28, 2023
Tratcher
reviewed
Feb 28, 2023
| { | ||
| UseProxy = false, | ||
| AllowAutoRedirect = false, | ||
| AutomaticDecompression = DecompressionMethods.None, |
Member
There was a problem hiding this comment.
@MihaZupan These are the settings we use elsewhere for proxying requests, but that's not applicable here is it, this is just used to retrieve config data? The defaults seem more applicable, especially for decompression.
Member
There was a problem hiding this comment.
Most of these shouldn't matter, but I agree decompression may be useful to keep on by default.
#2054
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #1926 , make Receiver's HttpClient instance from ReceiverOptions.
Fixes #1926