Workaround EventListener bug when consuming metrics#2104
Merged
MihaZupan merged 1 commit intodotnet:mainfrom Apr 18, 2023
Merged
Workaround EventListener bug when consuming metrics#2104MihaZupan merged 1 commit intodotnet:mainfrom
MihaZupan merged 1 commit intodotnet:mainfrom
Conversation
Tratcher
approved these changes
Apr 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2102
I confirmed manually that this does resolve the issue. I'm not sure we can have a reliable test for this without tooling like
RemoteExecutorsince the EventSources and listeners are all global in a given process.