Enable AOT compatibility for Yarp.Telemetry.Consumption#2146
Merged
MihaZupan merged 2 commits intodotnet:mainfrom May 24, 2023
Merged
Enable AOT compatibility for Yarp.Telemetry.Consumption#2146MihaZupan merged 2 commits intodotnet:mainfrom
MihaZupan merged 2 commits intodotnet:mainfrom
Conversation
Also fix a simple warning in Yarp.Kubernetes.Controller. The rest of the warnings in this project will be addressed in dotnet#2145.
MihaZupan
approved these changes
May 24, 2023
Member
MihaZupan
left a comment
MihaZupan
left a comment
There was a problem hiding this comment.
How come something like
https://github.com/microsoft/reverse-proxy/blob/d6fee86a9af9537ac8c7baad17460d1f0aa4d3fa/src/TelemetryConsumption/TelemetryConsumptionExtensions.cs#L89
does not raise a warning, but something like
https://github.com/microsoft/reverse-proxy/blob/7ef816467bb5bd0e82f08898a800e546ca0f86b9/src/ReverseProxy/Management/ReverseProxyServiceCollectionExtensions.cs#L122
does?
See https://github.com/dotnet/runtime/issues/86720 for why the warning isn't being raised.
Member
Author
|
Oh wow, nice catch! This is a bug in the analyzer. dotnet/roslyn#68420. I've fixed the warning and ensured when I publish an app rooting both Yarp assemblies there aren't any warnings from the trimming tool (which is separate from the Roslyn analyzer). |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also fix a simple warning in Yarp.Kubernetes.Controller. The rest of the warnings in this project will be addressed in #2145.
Follow up to #2144 (comment)