Update NotContains match mode for Header and QueryParameters to support missing/empty values#2258
Merged
MihaZupan merged 6 commits intodotnet:mainfrom Sep 26, 2023
Merged
Conversation
Contributor
Author
@microsoft-github-policy-service agree company="Microsoft" |
Tratcher
reviewed
Sep 25, 2023
MihaZupan
approved these changes
Sep 26, 2023
Member
MihaZupan
left a comment
There was a problem hiding this comment.
Thanks, I just changed the style a little bit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #2260
Currently the NotContains modes for both Header and QueryParameter matches do not match correctly when the value of the header/query is empty or if the key does not exist entirely.
Updated the match logic to the below (assuming any non-empty request values match the value specified by the route):