Skip to content

Comments

add OutputCachePolicy support#2328

Merged
Tratcher merged 12 commits intodotnet:mainfrom
witskeeper:main
Nov 28, 2023
Merged

add OutputCachePolicy support#2328
Tratcher merged 12 commits intodotnet:mainfrom
witskeeper:main

Conversation

@witskeeper
Copy link
Contributor

@witskeeper witskeeper commented Nov 15, 2023

add OutputCachePolicy to RouteConfig.cs

Tratcher
Tratcher reviewed Nov 15, 2023
View reviewed changes
Copy link
Member

@Tratcher Tratcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a brief description of output caching support to the docs. You can copy timeouts or RateLimiting. Also update the TOC.
https://github.com/microsoft/reverse-proxy/tree/main/docs/docfx/articles

Tratcher
Tratcher reviewed Nov 15, 2023
View reviewed changes
Kahbazi
Kahbazi reviewed Nov 17, 2023
View reviewed changes
Tratcher
Tratcher reviewed Nov 17, 2023
View reviewed changes
Tratcher
Tratcher reviewed Nov 20, 2023
View reviewed changes
@Tratcher Tratcher enabled auto-merge (squash) November 20, 2023 18:47
Tratcher
Tratcher requested changes Nov 20, 2023
View reviewed changes
Copy link
Member

@Tratcher Tratcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed this didn't update the ConfigValidator.

FYI there's a big refactor happening there right now that could cause conflicts. #2293

@Tratcher Tratcher mentioned this pull request Nov 20, 2023
Merged
@witskeeper
Copy link
Contributor Author

witskeeper commented Nov 21, 2023

I noticed this didn't update the ConfigValidator.

FYI there's a big refactor happening there right now that could cause conflicts. #2293

i can update the Validator after #2293 merged .

@Tratcher
Copy link
Member

Tratcher commented Nov 22, 2023

#2293 has been merged.

auto-merge was automatically disabled November 23, 2023 08:08

Head branch was pushed to by a user without write access

@witskeeper
Copy link
Contributor Author

witskeeper commented Nov 23, 2023 •
edited
Loading

#2293 has been merged.

done

Tratcher
Tratcher approved these changes Nov 27, 2023
View reviewed changes
Copy link
Member

@Tratcher Tratcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@witskeeper witskeeper mentioned this pull request Nov 28, 2023
Closed
@Tratcher Tratcher added this to the YARP 2.x milestone Nov 28, 2023
@Tratcher Tratcher merged commit 3853af1 into dotnet:main Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Tratcher Tratcher Tratcher approved these changes

@MihaZupan MihaZupan Awaiting requested review from MihaZupan MihaZupan is a code owner

@benjaminpetit benjaminpetit Awaiting requested review from benjaminpetit benjaminpetit is a code owner

+1 more reviewer

@Kahbazi Kahbazi Kahbazi left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

YARP 2.2.0-preview1

Development

Successfully merging this pull request may close these issues.

4 participants

@witskeeper @Tratcher @Kahbazi @MihaZupan