Fix Forwarded header for IPv4 with dual stack sockets#2509
Merged
MihaZupan merged 4 commits intodotnet:mainfrom May 20, 2024
Merged
Fix Forwarded header for IPv4 with dual stack sockets#2509MihaZupan merged 4 commits intodotnet:mainfrom
MihaZupan merged 4 commits intodotnet:mainfrom
Conversation
Contributor
Author
|
@microsoft-github-policy-service agree company="Microsoft" |
MihaZupan
reviewed
May 18, 2024
Member
MihaZupan
left a comment
MihaZupan
left a comment
There was a problem hiding this comment.
Thank you.
Could you move this logic into AppendNode such that it also applies to by='s LocalIpAddress?
Contributor
Author
|
Pulled out handling for both IP addresses |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to #2400 but for the
Forwardedheader