Bug 3337 messaging age barrier#3354
Merged
zorkian merged 2 commits intodreamwidth:mainfrom Dec 3, 2024
Merged
Conversation
Contributor
Author
|
I'll do a style conformance pass (http://wiki.dreamwidth.net/wiki/index.php/Programming_Guidelines for my reference) at the end, but a substance review on the current state would be nice. |
Contributor
Author
|
Assumption check: are you waiting for me to do something before you review, or should I wait patiently until someone has time to look at this? |
Member
|
You don't need to do anything; I am just slow and I guess nobody else has had a chance. |
Contributor
|
At a quick look-over it seems good to me, but because it's a safety feature I'm not quite comfortable signing off on this by myself and would prefer actual staff have a look too. |
Member
|
Thank you for writing excellent tests for this and covering all the edge cases! It looks good to me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CODE TOUR: Prevent users under 18 from PM'ing those 18 and over, and conversely.
Fixes #3337
(Note: this probably needs some style fixes. I'm rusty on that.)