new profile services don't have legacy userprops#3444
Merged
alierak merged 1 commit intodreamwidth:mainfrom Jan 17, 2025
Merged
new profile services don't have legacy userprops#3444alierak merged 1 commit intodreamwidth:mainfrom
alierak merged 1 commit intodreamwidth:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new profile services included
userpropdb values even though those were only intended for legacy values, and those userprops didn't actually ever exist. Fixing that uncovered a bug where services without a legacy userprop weren't being skipped when trying to display the nonexistent legacy values in the user profile, so the entire page died with a database error.CODE TOUR: new services (steam, spotify, squidgeworld) were causing the profile page to die with a database error; this should fix it.