also define $FC and $FCFLAGS in build environment#1394

boegel · 2015-09-18T15:40:56Z

fix for #1392

boegel · 2015-09-18T15:41:29Z

@geimer: can you take a look at this before I trim the edges?

Should we also define $F77FLAGS, while we're at it?

hpcugentbot · 2015-09-18T16:02:22Z

EasyBuild framework unit test suite FAILed.

See https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2055/console for more details.

Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do.

boegel · 2015-09-18T16:37:38Z

Jenkins: test this please

hpcugentbot · 2015-09-18T18:42:07Z

EasyBuild framework unit test suite FAILed.

See https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2060/console for more details.

Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do.

geimer · 2015-09-21T07:16:51Z

@boegel: I can take a look, however, this definitely won't happen before next week. And even this may be wishful thinking...

geimer · 2015-10-10T11:01:23Z

@boegel Regarding $F77FLAGS: GNU autotools will use $FFLAGS for $F77 and $FCFLAGS for $FC. The $F90 variable and the associated $F90FLAGS are somewhat non-standard (if one considers autotools to be standard...) and custom project-specific extensions. I've never seen $F77FLAGS anywhere, though that doesn't mean that it isn't used.

boegel · 2015-10-10T11:38:18Z

easybuild/tools/toolchain/compiler.py

@geimer: so, we should also define $FCFLAGS and $F77FLAGS?

geimer · 2015-10-10T11:52:41Z

@boegel: $FCFLAGS for sure. As I said, I personally haven't seen $F77FLAGS in the wild, but others may know more. At this point I would be reluctant to also add $F77FLAGS.

boegel · 2015-10-10T18:14:05Z

OK, I guess we'll stick to just $FCFLAGS then, thanks for your input @geimer! I'll try and finish this up in time for inclusion in EB v2.4.0

hpcugentbot · 2015-10-10T18:33:54Z

EasyBuild framework unit test suite FAILed.

See https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2164/console for more details.

Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do.

hpcugentbot · 2015-10-11T07:43:45Z

EasyBuild framework unit test suite FAILed.

See https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2166/console for more details.

Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do.

hpcugentbot · 2015-10-11T07:52:55Z

EasyBuild framework unit test suite FAILed.

See https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2167/console for more details.

Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do.

hpcugentbot · 2015-10-11T08:17:57Z

EasyBuild framework unit test suite FAILed.

See https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2168/console for more details.

Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do.

…in support for OpenMPI

boegel · 2015-10-11T09:19:52Z

easybuild/toolchains/mpi/mpich.py

@geimer: it seems like MPICH switched from mpif90 to mpifort in v3.1.2? Any idea about MPICH2?

That's right. They suddenly switch the name in a patch release! This also makes the sanity check fail when using a v3.1.1 easyconfig with --try-software-version. With respect to MPICH2, there is no need to worry as the entire release series provided mpif90.

Note that the mpifort thing also applies to recent versions of Open MPI (see https://www.open-mpi.org/faq/?category=mpi-apps#mpifort-vs-mpif77-and-mpif90), though they automatically create symlinks to mpif77 and mpif90 for backwards compatibility.

hpcugentbot · 2015-10-11T09:30:11Z

EasyBuild framework unit test suite FAILed.

See https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2169/console for more details.

Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do.

…lchain support for OpenMPI

hpcugentbot · 2015-10-11T16:11:44Z

EasyBuild framework unit test suite FAILed.

See https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2170/console for more details.

Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do.

hpcugentbot · 2015-10-11T16:23:03Z

EasyBuild framework unit test suite FAILed.

See https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2171/console for more details.

Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do.

hpcugentbot · 2015-10-12T09:37:38Z

EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2172/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

boegel · 2015-10-12T11:43:39Z

Summary of the changes made in here (since quite a bit of cleanup was done too):

also define $FC (same as $F90) in build environment (same for $MPIFC)
also define $FCFLAGS (same as $F90FLAGS) in build environment
define $MPICF* for MPICH depending on MPICH version
- mpif77/mpifort for MPICH v3.1.2 and newer
- mpif77/mpif90 for older MPCIH versions
define $MPICF* for OpenMPI depending on OpenMPI version
- mpifort for OpenMPI v1.7 and newer
- mpif77/mpif90 for older OpenMPI versions

@geimer: how does this sound?

hpcugentbot · 2015-10-12T13:06:59Z

EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2175/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

geimer · 2015-10-26T11:52:48Z

easybuild/toolchains/mpi/craympich.py

See easybuild/toolchains/mpi/mpich.py below: There you use a dict and MPI_COMPILER_VARIABLES. Consistency would be nice and using a dict is probably less error prone.

Forget it. In mpich.py it's defined at runtime...

No, I think this is a valid remark.

geimer · 2015-10-26T14:05:01Z

@boegel: Visually looks good to me; my comments are really nitpicking ;-) I've also tried to build Open MPI 1.10.0 using the Intel compilers on top of this PR w/o having FC set in configopts (like in #1392) and the build worked out fine.

hpcugentbot · 2015-10-27T08:34:21Z

EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2236/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

boegel · 2015-10-27T09:26:36Z

Going in, thanks for the review @geimer!

also define $FC and $FCFLAGS in build environment

also define $FC in build environment

448eaa5

boegel mentioned this pull request Sep 18, 2015

Intel Ifort and FC compiler variable #1392

Closed

boegel added this to the v2.4.0 milestone Sep 18, 2015

boegel reviewed Oct 10, 2015
View reviewed changes

easybuild/tools/toolchain/compiler.py Outdated

Copy link

Member Author

boegel Oct 10, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@geimer: so, we should also define $FCFLAGS and $F77FLAGS?

boegel added 2 commits October 10, 2015 20:20

also define

7f9ee97

Merge branch 'develop' into FC

b11d76e

fix typo

febf4fe

boegel changed the title ~~also define $FC in build environment (WIP)~~ also define $FC in build environment Oct 11, 2015

boegel changed the title ~~also define $FC in build environment~~ also define $FC and $FCFLAGS in build environment Oct 11, 2015

fix another typo

2e8cba3

fix moar issues

3c1e837

set MPI wrapper comments via _set_compiler_vars in openmpi.py toolcha…

94e09cd

…in support for OpenMPI

boegel reviewed Oct 11, 2015
View reviewed changes

set MPI wrapper comments via _set_mpi_compiler_vars in openmpi.py too…

5041846

…lchain support for OpenMPI

fix typo

72d4835

boegel added 2 commits October 12, 2015 09:08

fix broken checks

1ed1b29

pick MPICH MPI compiler wrappers based on version, fix broken tests

277a402

revert change in test imkl module

b018be7

geimer reviewed Oct 26, 2015
View reviewed changes

fix @geimer's remarks

3c89573

boegel added a commit that referenced this pull request Oct 27, 2015

Merge pull request #1394 from boegel/FC

1c8d20e

also define $FC and $FCFLAGS in build environment

boegel merged commit 1c8d20e into easybuilders:develop Oct 27, 2015

boegel deleted the FC branch October 27, 2015 09:26

This was referenced Nov 1, 2015

correctly handle having both $FC(FLAGS) and $F90(FLAGS) defined when building MVAPICH2 easybuilders/easybuild-easyblocks#732

Merged

fix MPI compiler wrapper env vars for toolchains using psmpi #1454

Merged

boegel mentioned this pull request Jan 27, 2016

stabilize Cray support #1390

Closed

17 tasks

boegel mentioned this pull request Feb 11, 2016

don't hardcode CC/CXX in OpenMPI easyconfigs easybuilders/easybuild-easyconfigs#2472

Merged

Conversation

boegel commented Sep 18, 2015

Uh oh!

boegel commented Sep 18, 2015

Uh oh!

hpcugentbot commented Sep 18, 2015

Uh oh!

boegel commented Sep 18, 2015

Uh oh!

hpcugentbot commented Sep 18, 2015

Uh oh!

geimer commented Sep 21, 2015

Uh oh!

geimer commented Oct 10, 2015

Uh oh!

boegel Oct 10, 2015

Choose a reason for hiding this comment

Uh oh!

geimer commented Oct 10, 2015

Uh oh!

boegel commented Oct 10, 2015

Uh oh!

hpcugentbot commented Oct 10, 2015

Uh oh!

hpcugentbot commented Oct 11, 2015

Uh oh!

hpcugentbot commented Oct 11, 2015

Uh oh!

hpcugentbot commented Oct 11, 2015

Uh oh!

boegel Oct 11, 2015

Choose a reason for hiding this comment

Uh oh!

geimer Oct 11, 2015

Choose a reason for hiding this comment

Uh oh!

hpcugentbot commented Oct 11, 2015

Uh oh!

hpcugentbot commented Oct 11, 2015

Uh oh!

hpcugentbot commented Oct 11, 2015

Uh oh!

hpcugentbot commented Oct 12, 2015

Uh oh!

boegel commented Oct 12, 2015

Uh oh!

hpcugentbot commented Oct 12, 2015

Uh oh!

geimer Oct 26, 2015

Choose a reason for hiding this comment

Uh oh!

geimer Oct 26, 2015

Choose a reason for hiding this comment

Uh oh!

boegel Oct 27, 2015

Choose a reason for hiding this comment

Uh oh!

geimer commented Oct 26, 2015

Uh oh!

hpcugentbot commented Oct 27, 2015

Uh oh!

boegel commented Oct 27, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants