Skip to content

add support for auto-converting to expected value type for easyconfig parameters#1428

Merged
boegel merged 3 commits intoeasybuilders:developfrom
boegel:easyconfig_param_type_conversion
Oct 14, 2015
Merged

add support for auto-converting to expected value type for easyconfig parameters#1428
boegel merged 3 commits intoeasybuilders:developfrom
boegel:easyconfig_param_type_conversion

Conversation

@boegel
Copy link
Member

@boegel boegel commented Oct 14, 2015

No description provided.

@boegel
Copy link
Member Author

boegel commented Oct 14, 2015

@wpoely86, @Caylo: please review?

wpoely86
wpoely86 reviewed Oct 14, 2015
View reviewed changes
test/framework/type_checking.py
Copy link
Member

@wpoely86 wpoely86 Oct 14, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self.assertEqual(convert_value_type('1.6', int), 1) ?

Copy link
Member

@wpoely86 wpoely86 Oct 14, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self.assertEqual(convert_value_type('5', float), 5.0) ?

@wpoely86
Copy link
Member

wpoely86 commented Oct 14, 2015

lgtm

@Caylo
Copy link
Contributor

Caylo commented Oct 14, 2015

nothing to add here :)

@hpcugentbot
Copy link

hpcugentbot commented Oct 14, 2015

EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2200/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@boegel boegel added this to the v2.4.0 milestone Oct 14, 2015
@hpcugentbot
Copy link

hpcugentbot commented Oct 14, 2015

EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2201/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@boegel
Copy link
Member Author

boegel commented Oct 14, 2015

Thanks for the review @wpoely86 and @Caylo!

boegel added a commit that referenced this pull request Oct 14, 2015
@boegel
Merge pull request #1428 from boegel/easyconfig_param_type_conversion
50635a0 
add support for auto-converting to expected value type for easyconfig parameters
@boegel boegel merged commit 50635a0 into easybuilders:develop Oct 14, 2015
@boegel boegel deleted the easyconfig_param_type_conversion branch October 14, 2015 14:28
@boegel boegel mentioned this pull request Oct 21, 2015
Merged
@Caylo Caylo mentioned this pull request Oct 28, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v2.4.0

Development

Successfully merging this pull request may close these issues.

4 participants

@boegel @wpoely86 @Caylo @hpcugentbot