Skip to content

ignore __init__.py files in --include-*#1704

Merged
boegel merged 1 commit intoeasybuilders:developfrom
boegel:include_ignore_init
Mar 28, 2016
Merged

ignore __init__.py files in --include-*#1704
boegel merged 1 commit intoeasybuilders:developfrom
boegel:include_ignore_init

Conversation

@boegel
Copy link
Member

@boegel boegel commented Mar 26, 2016

fix for problem reported in #1697

cc @jgphpc

@boegel boegel added this to the v2.8.0 milestone Mar 26, 2016
@hpcugentbot
Copy link

EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2913/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@boegel
Copy link
Member Author

boegel commented Mar 27, 2016

@wpoely86 please review?

@wpoely86
Copy link
Member

looks good but maybe also protect against __init__.pyc?

@boegel
Copy link
Member Author

boegel commented Mar 28, 2016

Having an __init__.pyc is irrelevant; the non-init *.py files are symlinked in a temporary directory, and then eb adds it's own __init__.py along with the symlinks. If the __init__.py files are symlinked too, things break.

So, good to go imho, thanks for the review @wpoely86!

@boegel boegel merged commit 7f07630 into easybuilders:develop Mar 28, 2016
@boegel boegel deleted the include_ignore_init branch March 28, 2016 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants