Skip to content

fix error message on missing module command#1772

Merged
boegel merged 1 commit intoeasybuilders:developfrom
boegel:bootstrap_fix_modcmd_error
May 19, 2016
Merged

fix error message on missing module command#1772
boegel merged 1 commit intoeasybuilders:developfrom
boegel:bootstrap_fix_modcmd_error

Conversation

@boegel
Copy link
Member

@boegel boegel commented May 19, 2016

reported by @robertdfrench

without this patch, in case no module commands were found in $PATH (and with $LMOD_CMD and $EASYBUILD_MODULES_TOOL undefined):

[[INFO]] Installation prefix /tmp/adfsghjm
Traceback (most recent call last):
  File "/Users/kehoste/work/easybuild-framework/easybuild/scripts/bootstrap_eb.py", line 788, in <module>
    main()
  File "/Users/kehoste/work/easybuild-framework/easybuild/scripts/bootstrap_eb.py", line 554, in main
    modtool = check_module_command(tmpdir)
  File "/Users/kehoste/work/easybuild-framework/easybuild/scripts/bootstrap_eb.py", line 208, in check_module_command
    "Known module commands are checked in order, and include: %s" % ', '.join(mod_cmds),
TypeError: sequence item 0: expected string, tuple found

with this patch:

[[INFO]] Installation prefix /tmp/adfsghjm
[[ERROR]] Could not find any module command, make sure one available in your $PATH.
Known module commands are checked in order, and include: modulecmd, lmod, modulecmd.tcl
Check the output of 'type module' to determine the location of the module command you are using.

@boegel boegel added this to the v2.9.0 milestone May 19, 2016
@boegel
Copy link
Member Author

boegel commented May 19, 2016

@wpoely86 please review? pretty trivial though...

@wpoely86
Copy link
Member

👍

@boegel
Copy link
Member Author

boegel commented May 19, 2016

Thanks for the review @wpoely86, and @robertdfrench for reporting the bug.

@boegel boegel merged commit 834fcbf into easybuilders:develop May 19, 2016
@boegel boegel deleted the bootstrap_fix_modcmd_error branch May 19, 2016 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants