fix packaging issue with non-Python scripts in easybuild/scripts#2015
Merged
boegel merged 3 commits intoeasybuilders:developfrom Nov 23, 2016
Merged
fix packaging issue with non-Python scripts in easybuild/scripts#2015boegel merged 3 commits intoeasybuilders:developfrom
boegel merged 3 commits intoeasybuilders:developfrom
Conversation
Member
Author
|
@wpoely86 please review |
This was referenced Nov 22, 2016
rjeschmi
approved these changes
Nov 23, 2016
Contributor
rjeschmi
left a comment
rjeschmi
left a comment
There was a problem hiding this comment.
This looks ok. Definitely an improvement. I wonder if this should maybe only trigger pre-dist. I don't know enough about travis
wpoely86
approved these changes
Nov 23, 2016
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix for #2006, see change to
MANIFEST.inI also changed the Travis config to run the test suite differently so we'll actually notice any packaging issues in the future.