make tests more robust against running headless#2016
Merged
boegel merged 1 commit intoeasybuilders:developfrom Nov 23, 2016
Merged
make tests more robust against running headless#2016boegel merged 1 commit intoeasybuilders:developfrom
boegel merged 1 commit intoeasybuilders:developfrom
Conversation
Member
Author
|
@wpoely86 please review |
wpoely86
reviewed
Nov 23, 2016
| if isinstance(self.modtool, Lmod): | ||
| # GCC/4.6.3 is nowhere to be found (in $MODULEPATH) | ||
| load_err_msg = r"The following module\(s\) are unknown" | ||
| load_err_msg = r"The[\s\n]*following[\s\n]*module\(s\)[\s\n]*are[\s\n]*unknown" |
Member
Author
There was a problem hiding this comment.
Why? Lmod is wrapping output lines differently in a headless (0-width) terminal, so the whole message doesn't fit on a single line anymore, it's wrapped.
Member
There was a problem hiding this comment.
It shouldn't be wrapping at all if the with is 0?
Member
Author
There was a problem hiding this comment.
well, it does
remember, I'm also testing with old Lmod versions, so this is just something we need to deal with (it's also not a big issue imho)
we're not testing Lmod here, we're checking that some module is not available because EB didn't put it there
wpoely86
approved these changes
Nov 23, 2016
Member
Author
|
Thanks for the critical review @wpoely86! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For some reason unclear to me, a couple of the EasyBuild framework tests have been failing when running from my fork (https://github.com/boegel/easybuild-framework), with errors like this:
I'm not sure why they only fail for my fork and not the central repos, since the test setup is exactly the same. My best guess is that Travis is gradually rolling out some changes which have not yet hit all test environments.
This change makes the affected tests more robust against running headless. For the
multidifftest, it makes some of the test cases slightly less strict, but that shouldn't affect the capability to catch regression (since the test is quite extensively).