add option to define SINGULARITY_TMPDIR#2483
Merged
boegel merged 3 commits intoeasybuilders:developfrom Apr 25, 2018
Merged
Conversation
…th --tmpdir), take into account that it may not be specified + enhance tests
boegel
requested changes
Apr 25, 2018
easybuild/tools/containers.py
Outdated
| singularity = which('singularity') | ||
|
|
||
| cmd = "sudo %s build %s %s %s" % (singularity, cmd_opts, img_path, def_path) | ||
| singularity_tmp = build_option('container_tmp_path') |
Member
There was a problem hiding this comment.
@migueldiascosta What if this is not specified, you'll inject SINGULARITY_TMPDIR=None into the command?
Fixes in migueldiascosta#1
Member
Author
There was a problem hiding this comment.
@boegel you're right, I assumed it would be empty and singularity would default to /tmp (and thought I had tested it but apparently hadn't)
--container-tmpdir fix + test
Member
|
Thanks @migueldiascosta! |
boegel
approved these changes
Apr 25, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Singularity defaults to building the images in
/tmp(http://singularity.lbl.gov/build-environment#temporary-folders), which will fail if it is not large enoughAdditionally, this environment variable must be defined in the root shell where singularity is run, via sudo.
This adds options to define the path as passes it to singularity.
cc @shahzebsiddiqui @boegel