templating must be disabled when parsing dependencies in EasyConfig.parse#2566
Merged
akesandgren merged 2 commits intoeasybuilders:developfrom Sep 6, 2018
Merged
Conversation
Contributor
|
Ah, should have thought of that before... |
Contributor
|
Going in, thanks @boegel |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix for problem introduced in #2562 (cc @akesandgren)
Before the changes in #2562, it was OK that templating was enabled when
_parse_dependencywas called, because the templating only occurs when easyconfig parameters are fetched viaself(usingself[key), i.e. theEasyConfiginstance. When the easyconfig parameters are fetching vialocal_vars[key]there is no templating sincelocal_varsis a regulardictvalue...also fixes easybuilders/easybuild-easyconfigs#6818