deprecate goolf and goolfc toolchains#2676
Merged
verdurin merged 2 commits intoeasybuilders:developfrom Dec 2, 2018
Merged
Conversation
houndci-bot
reviewed
Nov 29, 2018
Member
|
@boegel - do you want testing of this, or a visual inspection? |
Member
Author
|
@verdurin There's little point in testing this imho, since it's mainly about updating the framework tests to avoid the use of So it boils down to visual inspection for any "suspicious" changes imho. |
verdurin
approved these changes
Dec 2, 2018
Member
verdurin
left a comment
verdurin
left a comment
There was a problem hiding this comment.
Have skimmed through it and all looks innocuous...
This was referenced Dec 5, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deprecating the
goolfandgoolfctoolchains triggers a lot of (trivial, in the end) changes in the tests.The semantics of the tests haven't changed, it's basically just a modernization sweep...