avoid relying on order in which keys are processed in to_dependency#2804
Merged
migueldiascosta merged 1 commit intoeasybuilders:developfrom Mar 8, 2019
Merged
Conversation
Member
|
Going in, thanks @boegel! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When looking into extending the support in the
4.xto other Python 3.x versions beyond 3.6, I ran into a failing test forto_dependencybecause of the order in which the keys were being iterated over.If a bogus key-pair value is included in the dict passed to
to_dependency(which is supposed to trigger an exceptionFound unexpected (key, value) pair), and it gets processed beforenameorversionare, then it is accepted as a valid key, which is incorrect.This patch fixes it by first considering
name/versionbefore the other keys, so the order in which the remaining keys are processed doesn't matter...