skip validation when copying EasyConfig object for extension#3071
Merged
akesandgren merged 2 commits intoeasybuilders:developfrom Nov 6, 2019
Merged
skip validation when copying EasyConfig object for extension#3071akesandgren merged 2 commits intoeasybuilders:developfrom
akesandgren merged 2 commits intoeasybuilders:developfrom
Conversation
akesandgren
reviewed
Nov 5, 2019
Contributor
akesandgren
left a comment
akesandgren
left a comment
There was a problem hiding this comment.
Yeah, this looks sane. Is that the only place cfg.copy is used?
Member
Author
|
@akesandgren Basically, yes. I'd like to get this covered in the tests somehow too, need to think about how to do that exactly... |
Contributor
|
This resolves the issues I've seen with OS dependencies on RHEL8. Thanks! |
…ped when copying parent EasyConfig object for extensions
Member
Author
|
Thanks a lot for confirming the fix @terjekv! I've enhanced one of the tests to try and ensure that we don't accidentally reverse this fix, which makes the PR good to go... |
Contributor
|
Going in, thanks @boegel! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently when an extension is initialized, the
EasyConfiginstance of the "parent" is copied into the extension (since stuff liketoolchainetc. is also relevant for installing the extension).By default, this results in re-validating the easyconfig file (which includes re-checking the OS dependencies), which is silly.
Even worse, it leads to problems like the ones reported in easybuilders/easybuild-easyconfigs#8661 since commands like
rpm -qmay break when particular modules (likeXZare loaded).cc @zao, @terjekv, @akesandgren