make EasyConfigParser.get_config_dict return a copy rather than a reference#3692
Merged
migueldiascosta merged 6 commits intoeasybuilders:developfrom May 21, 2021
Merged
make EasyConfigParser.get_config_dict return a copy rather than a reference#3692migueldiascosta merged 6 commits intoeasybuilders:developfrom
migueldiascosta merged 6 commits intoeasybuilders:developfrom
Conversation
boegel
changed the title
Flamefire
approved these changes
May 21, 2021
Contributor
Flamefire
left a comment
Flamefire
left a comment
There was a problem hiding this comment.
I would have done it at a higher level (i.e. in the parser which has-a format object to avoid duplicating this, but this works too. Thanks!
For future reference as written in Slack:
The faster solution would be to copy the dict only on (potential) modification, e.g. when it is assigned into the EC (set_keys) because now we copy even if we only read from it (e.g. in the EC test suite). However it was decided to go for the safer solution and avoid the potential for accidental modification at the cost of a (comparatively cheap) copy of a dict
Member
|
Going in, thanks @boegel! |
boegel
changed the title
boegel
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #3691