Skip to content

Consider sources provided as dict in EasyBlock.check_checksums_for#3758

Merged
boegel merged 2 commits intoeasybuilders:developfrom
lexming:fix-chksum-dict
Jul 2, 2021
Merged

Consider sources provided as dict in EasyBlock.check_checksums_for#3758
boegel merged 2 commits intoeasybuilders:developfrom
lexming:fix-chksum-dict

Conversation

@lexming
Copy link
Contributor

@lexming lexming commented Jun 24, 2021

I managed to break the tests by making an easyconfig where sources is a dict and checksums is also a dict. 🙂

Fixes failing tests in easybuilders/easybuild-easyconfigs#13141

Copy link
Member

@migueldiascosta migueldiascosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@migueldiascosta
Copy link
Member

worth adding a test in test/framework/type_checking.py?

Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel enabled auto-merge July 2, 2021 16:30
@boegel boegel merged commit 8e0a02f into easybuilders:develop Jul 2, 2021
@lexming lexming deleted the fix-chksum-dict branch December 13, 2021 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants