Skip to content

print error message in main_with_hooks function when EasyBuildError was raised#4380

Merged
smoors merged 1 commit intoeasybuilders:5.0.xfrom
boegel:fix_error_reporting
Nov 13, 2023
Merged

print error message in main_with_hooks function when EasyBuildError was raised#4380
smoors merged 1 commit intoeasybuilders:5.0.xfrom
boegel:fix_error_reporting

Conversation

@boegel
Copy link
Member

@boegel boegel commented Nov 13, 2023

also deprecates exitCode in print_error, replaced with exit_code (very small impact, since exitCode is not actually used anywhere in framework or easyblocks)

@boegel boegel added bug fix EasyBuild-5.0 EasyBuild 5.0 labels Nov 13, 2023
@boegel boegel added this to the 5.0 milestone Nov 13, 2023
@boegel boegel changed the title print error message when EasyBuildError was raised in main_with_hooks function print error message when EasyBuildError was raised in main_with_hooks function Nov 13, 2023
@boegel boegel changed the title print error message when EasyBuildError was raised in main_with_hooks function print error message in main_with_hooks function when EasyBuildError was raised Nov 13, 2023
Copy link
Contributor

@smoors smoors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smoors smoors merged commit 95e752c into easybuilders:5.0.x Nov 13, 2023
@boegel boegel deleted the fix_error_reporting branch November 13, 2023 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

No open projects
Status: No status

Development

Successfully merging this pull request may close these issues.

2 participants