symlink downloaded repo at specified commit when using --from-commit so easyconfigs for dependencies are found#4552
Merged
ocaisa merged 2 commits intoeasybuilders:developfrom Jun 7, 2024
Conversation
…so easyconfigs for dependencies are found
…ired for dependencies are found + fix check in test_github_from_pr
ocaisa
approved these changes
Jun 7, 2024
Member
ocaisa
left a comment
ocaisa
left a comment
There was a problem hiding this comment.
Regex is my enemy, I guess I need to learn it. LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #4540
https://github.com/boegel/easybuild-framework/actions/runs/9416046787/job/25938331232 shows that GitHub tests, which are skipped in context of running test suite for a PR because GitHub token is not available, are (still) passing.
Without this fix, the additional test case added to
test_from_commitfails, which shows it verifies the bug fix being fixed here.