fix ignoring of URLError in test_copy_ec_from_commit#5077
Merged
boegel merged 2 commits intoeasybuilders:developfrom Dec 18, 2025
Merged
fix ignoring of URLError in test_copy_ec_from_commit#5077boegel merged 2 commits intoeasybuilders:developfrom
test_copy_ec_from_commit#5077boegel merged 2 commits intoeasybuilders:developfrom
Conversation
When the exception is thrown and ignored `stdout` is unassigned so the following tests cannot be done.
C&P that code is not necessary when `tmpdir` isn't used or the catch is at the end of a test.
1 task
boegel
changed the title
test_copy_ec_from_commit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the exception is thrown and ignored
stdoutis unassigned so the following tests cannot be done.Fix regression from #4468.
See https://github.com/easybuilders/easybuild-framework/actions/runs/20333704730/job/58414942098?pr=5045
Note that CI will still fail with
And similar:
cc @boegel