Skip to content

fix 2 important bugs in configuration parsing#558

Merged
boegel merged 2 commits intoeasybuilders:developfrom
stdweird:fix_legacy_prefix
Mar 24, 2013
Merged

fix 2 important bugs in configuration parsing#558
boegel merged 2 commits intoeasybuilders:developfrom
stdweird:fix_legacy_prefix

Conversation

@stdweird
Copy link
Contributor

No description provided.

@stdweird
Copy link
Contributor Author

@boegel these need to go in, should fix issues reported by @ajdecon, everyone is affected by one of the 2 issues

@boegel
Copy link
Member

boegel commented Mar 24, 2013

Does this render #556 useless (except for the unit tests)?

Will this fix the use of $EASYBUILDPREFIX as well?

@boegel
Copy link
Member

boegel commented Mar 24, 2013

Apparently it also fixes the issue w.r.t. supporting the legacy way of configuring EasyBuild.

@stdweird: Can you briefly explain why you need the update? This fix is a lot cleaner than what I was doing in #556...

@boegel
Copy link
Member

boegel commented Mar 24, 2013

All unit tests pass, which includes the tests for config:

.........................................................
----------------------------------------------------------------------
Ran 57 tests in 189.957s

OK

@boegel
Copy link
Member

boegel commented Mar 24, 2013

This clearly fixes the problems, so merging it in.

I'm going to clean up #556 to make it only about the unit tests added there...

boegel added a commit that referenced this pull request Mar 24, 2013
fix 2 important bugs in configuration parsing
@boegel boegel merged commit 87666dd into easybuilders:develop Mar 24, 2013
@stdweird
Copy link
Contributor Author

@boegel without the update, the complete old easybuild_config.py was ignored as the olstyle naming was not converted. there is no prefix issue.

boegel added a commit to boegel/easybuild-framework that referenced this pull request Mar 25, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants