Conversation
In Clang-based toolchains, COMPILER_MODULE_NAME includes two items: 'Clang' and 'GCC'
easybuild/toolchains/cgmpich.py
Outdated
There was a problem hiding this comment.
Thanks. Fix pushed.
There was a problem hiding this comment.
Same here, I don't think you should set COMPILER_MODULE_NAME here, although it's less obvious than in Cgompi.
There was a problem hiding this comment.
Removing COMPILER_MODULE_NAME does not work. When building anything with ClangGCC (for example, hwloc-1.6.2-ClangGCC-1.1.2.eb) I get:
EasyBuildError: "EasyBuild crashed with an error (at easybuild/eb-install/lib/python2.6/site-packages/easybuild_framework-1.4.0dev-py2.6.egg/easybuild/tools/toolchain/toolchain.py:314 in prepare): List of toolchain dependency modules and toolchain definition do not match (set(['GCC', 'Clang']) vs set(['GCC']))"
There was a problem hiding this comment.
OK, that makes sense, it should indeed be there, my bad.
There was a problem hiding this comment.
No need to still set COMPILER_MODULE_NAME if you derive from ClangGCC?
There was a problem hiding this comment.
As discussed on IRC, it is required. ClangGcc has 'Clang' and 'GCC' in this list.
Clang does not have Fortran support, and thus it is not a complete compiler as far as EasyBuild is concerned.
…cluding Fortran support
|
@boegel I have addressed all your comments except the one about FP precision flags. |
easybuild/toolchains/clanggcc.py
Outdated
There was a problem hiding this comment.
This should be super(ClangGCC, self)
easybuild/toolchains/cgmpolf.py
Outdated
There was a problem hiding this comment.
COMPILER_MODULE_NAME is set correctly in ClangGCC, so no need to set it here?
There was a problem hiding this comment.
As discussed before on IRC, it will not work. ClangGCC defines it as 'Clang', 'GCC'.
There was a problem hiding this comment.
OK, I was confused here as you can also derive Cgmpolf on top of Cgmpich.
Actually, that's probably better...
There was a problem hiding this comment.
OK, I'm changing the inheritance hierarchies and retesting.
|
@boegel Fixed all comments except for precision flags. |
|
@boegel Changed inheritance hierarchy. |
|
@boegel Added floating point flags as suggested. |
…added in develop via easybuilders#585 This reverts commit 0b99ad0.
Add cgoolf unit test
…mework into clang-toolchains
add test module for GCC/4.7.2 + sync with develop
…mework into clang-toolchains
fix module load unit test + one very minor enhancement
…mework into clang-toolchains
add remove_module definition
2 participants
This pull request adds ClangGCC + {OpenMPI, MPICH} toolchains. Please review!
This change is required for pull request easybuilders/easybuild-easyconfigs#213