properly decode easyblock to module name#618
Merged
boegel merged 7 commits intoeasybuilders:developfrom Apr 25, 2013
Merged
Conversation
…ols for VSC-tools
|
exactly what we needed imho. |
boegel
added a commit
that referenced
this pull request
Apr 25, 2013
properly decode easyblock to module name
Contributor
There was a problem hiding this comment.
Hi folks,
although I am the source of this "bug" really, I wanted to ask you if from time to time you get confused to see things like:
VSC_minus_tools instead of VSC_dash_tools or even VSC_hyphen_tools; just give it a thought if you prefer a switch...
Member
Author
There was a problem hiding this comment.
The reason you went for minus is because of the Unicode naming for the character (http://www.fileformat.info/info/unicode/char/2212/index.htm), and because it matches nicely with plus.
No worries, there's no reason to doubt this imho.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.