fix Cpu vendor in systemtools#655
Merged
boegel merged 3 commits intoeasybuilders:developfrom Jul 1, 2013
Merged
Conversation
Member
There was a problem hiding this comment.
Do we want to keep listing the possible constants here? How about:
"""
Try to detect the CPU identifier, will return constant CPU vendor string (e.g., 'Intel', 'AMD', etc.).
"""
Member
There was a problem hiding this comment.
Because there a millons of CPU vendors out there, and... Ah, well, forget it, fine by me. ;-)
Author
There was a problem hiding this comment.
since we want to return a constant, so we can compare against it,
it will return 'UNKNOWN' which is probably better then a random string.
Member
|
@JensTimmerman: please review remarks to make this eligible for merging in time for v1.6. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this should fix #652