Skip to content

Fix: correctly reference the request body class for the /api/user/namespace/create operation#1414

Merged
amvanbaren merged 1 commit intoeclipse:masterfrom
netomi:fix/openapi-schema-for-namespace-create
Nov 19, 2025
Merged

Fix: correctly reference the request body class for the /api/user/namespace/create operation#1414
amvanbaren merged 1 commit intoeclipse:masterfrom
netomi:fix/openapi-schema-for-namespace-create

Conversation

@netomi
Copy link
Contributor

@netomi netomi commented Nov 14, 2025

This fixes #1413 .

@@ -1151,7 +1151,7 @@ public ResponseEntity<ResultJson> createNamespace(
summary = "Create a namespace",
requestBody = @io.swagger.v3.oas.annotations.parameters.RequestBody(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason we are doing this differently than on L1122? That seems to generate the correct spec and didn't require this specific requestBody in the annotation and inferred it from the method parameters instead.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tbh I was asking myself the same question.
It could also be removed, to be consistent with the rest.

Keep in mind, that this operation will probably be moved somewhere else anyway as this is a route only useful for the frontend and should not be exposed in the openapi spec imho.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me. I think consistency might be better in this case and remove it, but as long as the output is correct that's the most important thing.

@amvanbaren amvanbaren merged commit 17363f7 into eclipse:master Nov 19, 2025
2 checks passed
@netomi netomi deleted the fix/openapi-schema-for-namespace-create branch January 28, 2026 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OpenAPI spec references non-existent schema NamespaceJson

3 participants