docs(deployment): egg-scripts support windows#2788
Merged
fengmk2 merged 1 commit intoeggjs:masterfrom Jul 12, 2018
Merged
Conversation
4 tasks
atian25
reviewed
Jul 11, 2018
| Then we are able to use `npm start` and `npm stop` to manage application. | ||
|
|
||
| > Note: `egg-scripts` don't support Windows. | ||
| > Note: `egg-scripts` has limited support for Windows, see [#22](https://github.com/eggjs/egg-scripts/pull/22). |
Member
There was a problem hiding this comment.
how about wait for fully support, then updated this together ?
Contributor
Author
There was a problem hiding this comment.
Sure.
About limited support, I just want to put the notice: some people may failed to run wmic Path win32_process Where "Name = 'node.exe'" Get CommandLine,ProcessId on windows.
Codecov Report
@@ Coverage Diff @@
## master #2788 +/- ##
=======================================
Coverage 99.63% 99.63%
=======================================
Files 29 29
Lines 829 829
=======================================
Hits 826 826
Misses 3 3Continue to review full report at Codecov.
|
fengmk2
approved these changes
Jul 12, 2018
popomore
pushed a commit
that referenced
this pull request
Jul 12, 2018
docs(deployment): egg-scripts support windows (#2788)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpassesAffected core subsystem(s)
egg-scripts limited support for windows
Description of change
see #22