Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR disables the unbundle configuration option across all tsdown config files in the project. The change comments out the unbundle: true setting in 35 configuration files to modify the build behavior from unbundled to bundled output.
- Systematically commented out
unbundle: truein all tsdown configuration files - Affects both core and plugin modules to ensure consistent build configuration
- References an upstream issue in the eggjs/egg repository for context
Reviewed Changes
Copilot reviewed 35 out of 35 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| standalone/standalone/tsdown.config.ts | Disabled unbundle option for standalone module |
| plugin/tegg/tsdown.config.ts | Disabled unbundle option for tegg plugin |
| plugin/schedule/tsdown.config.ts | Disabled unbundle option for schedule plugin |
| plugin/orm/tsdown.config.ts | Disabled unbundle option for orm plugin |
| plugin/eventbus/tsdown.config.ts | Disabled unbundle option for eventbus plugin |
| plugin/dal/tsdown.config.ts | Disabled unbundle option for dal plugin |
| plugin/controller/tsdown.config.ts | Disabled unbundle option for controller plugin |
| plugin/config/tsdown.config.ts | Disabled unbundle option for config plugin |
| plugin/common/tsdown.config.ts | Disabled unbundle option for common plugin |
| plugin/aop/tsdown.config.ts | Disabled unbundle option for aop plugin |
| plugin/ajv/tsdown.config.ts | Disabled unbundle option for ajv plugin |
| core/types/tsdown.config.ts | Disabled unbundle option for types core module |
| core/transaction-decorator/tsdown.config.ts | Disabled unbundle option for transaction-decorator core module |
| core/test-util/tsdown.config.ts | Disabled unbundle option for test-util core module |
| core/tegg/tsdown.config.ts | Disabled unbundle option for tegg core module |
| core/standalone-decorator/tsdown.config.ts | Disabled unbundle option for standalone-decorator core module |
| core/schedule-decorator/tsdown.config.ts | Disabled unbundle option for schedule-decorator core module |
| core/runtime/tsdown.config.ts | Disabled unbundle option for runtime core module |
| core/orm-decorator/tsdown.config.ts | Disabled unbundle option for orm-decorator core module |
| core/metadata/tsdown.config.ts | Disabled unbundle option for metadata core module |
| core/loader/tsdown.config.ts | Disabled unbundle option for loader core module |
| core/lifecycle/tsdown.config.ts | Disabled unbundle option for lifecycle core module |
| core/eventbus-runtime/tsdown.config.ts | Disabled unbundle option for eventbus-runtime core module |
| core/eventbus-decorator/tsdown.config.ts | Disabled unbundle option for eventbus-decorator core module |
| core/dynamic-inject/tsdown.config.ts | Disabled unbundle option for dynamic-inject core module |
| core/dynamic-inject-runtime/tsdown.config.ts | Disabled unbundle option for dynamic-inject-runtime core module |
| core/dal-runtime/tsdown.config.ts | Disabled unbundle option for dal-runtime core module |
| core/dal-decorator/tsdown.config.ts | Disabled unbundle option for dal-decorator core module |
| core/core-decorator/tsdown.config.ts | Disabled unbundle option for core-decorator core module |
| core/controller-decorator/tsdown.config.ts | Disabled unbundle option for controller-decorator core module |
| core/common-util/tsdown.config.ts | Disabled unbundle option for common-util core module |
| core/background-task/tsdown.config.ts | Disabled unbundle option for background-task core module |
| core/aop-runtime/tsdown.config.ts | Disabled unbundle option for aop-runtime core module |
| core/aop-decorator/tsdown.config.ts | Disabled unbundle option for aop-decorator core module |
| core/ajv-decorator/tsdown.config.ts | Disabled unbundle option for ajv-decorator core module |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of ChangesHello @fengmk2, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request systematically disables the 'unbundle' configuration option within the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request disables the unbundle option in tsdown.config.ts for multiple packages by commenting out the unbundle: true line. While this achieves the goal, a cleaner approach for maintainability would be to remove the line entirely instead of commenting it out. This avoids clutter and potential confusion from stale code in the configuration files. I've added specific suggestions to each affected file to remove the commented line.
| 'src/index.ts', | ||
| ], | ||
| unbundle: true, | ||
| // unbundle: true, |
There was a problem hiding this comment.
For better maintainability, it's preferable to remove this line entirely rather than commenting it out. If the goal is to use the default value for unbundle (which is likely false), removing the line makes the configuration cleaner and avoids potential confusion from stale commented-out code.
| 'src/index.ts', | ||
| ], | ||
| unbundle: true, | ||
| // unbundle: true, |
There was a problem hiding this comment.
For better maintainability, it's preferable to remove this line entirely rather than commenting it out. If the goal is to use the default value for unbundle (which is likely false), removing the line makes the configuration cleaner and avoids potential confusion from stale commented-out code.
| 'src/index.ts', | ||
| ], | ||
| unbundle: true, | ||
| // unbundle: true, |
There was a problem hiding this comment.
For better maintainability, it's preferable to remove this line entirely rather than commenting it out. If the goal is to use the default value for unbundle (which is likely false), removing the line makes the configuration cleaner and avoids potential confusion from stale commented-out code.
| 'src/index.ts', | ||
| ], | ||
| unbundle: true, | ||
| // unbundle: true, |
There was a problem hiding this comment.
For better maintainability, it's preferable to remove this line entirely rather than commenting it out. If the goal is to use the default value for unbundle (which is likely false), removing the line makes the configuration cleaner and avoids potential confusion from stale commented-out code.
| 'src/index.ts', | ||
| ], | ||
| unbundle: true, | ||
| // unbundle: true, |
There was a problem hiding this comment.
For better maintainability, it's preferable to remove this line entirely rather than commenting it out. If the goal is to use the default value for unbundle (which is likely false), removing the line makes the configuration cleaner and avoids potential confusion from stale commented-out code.
| export default defineConfig({ | ||
| entry: 'src/**/*.ts', | ||
| unbundle: true, | ||
| // unbundle: true, |
There was a problem hiding this comment.
For better maintainability, it's preferable to remove this line entirely rather than commenting it out. If the goal is to use the default value for unbundle (which is likely false), removing the line makes the configuration cleaner and avoids potential confusion from stale commented-out code.
| export default defineConfig({ | ||
| entry: 'src/**/*.ts', | ||
| unbundle: true, | ||
| // unbundle: true, |
There was a problem hiding this comment.
For better maintainability, it's preferable to remove this line entirely rather than commenting it out. If the goal is to use the default value for unbundle (which is likely false), removing the line makes the configuration cleaner and avoids potential confusion from stale commented-out code.
| export default defineConfig({ | ||
| entry: 'src/**/*.ts', | ||
| unbundle: true, | ||
| // unbundle: true, |
There was a problem hiding this comment.
For better maintainability, it's preferable to remove this line entirely rather than commenting it out. If the goal is to use the default value for unbundle (which is likely false), removing the line makes the configuration cleaner and avoids potential confusion from stale commented-out code.
| export default defineConfig({ | ||
| entry: 'src/**/*.ts', | ||
| unbundle: true, | ||
| // unbundle: true, |
There was a problem hiding this comment.
For better maintainability, it's preferable to remove this line entirely rather than commenting it out. If the goal is to use the default value for unbundle (which is likely false), removing the line makes the configuration cleaner and avoids potential confusion from stale commented-out code.
| 'src/index.ts', | ||
| ], | ||
| unbundle: true, | ||
| // unbundle: true, |
There was a problem hiding this comment.
For better maintainability, it's preferable to remove this line entirely rather than commenting it out. If the goal is to use the default value for unbundle (which is likely false), removing the line makes the configuration cleaner and avoids potential confusion from stale commented-out code.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## next #350 +/- ##
=======================================
Coverage 86.11% 86.11%
=======================================
Files 279 279
Lines 7995 7995
Branches 1204 1190 -14
=======================================
Hits 6885 6885
Misses 1110 1110 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1 participant
eggjs/egg#5581